Re: [PATCH] fix module paramater permissions in radeon_base.c

2005-03-01 Thread Benjamin Herrenschmidt
On Tue, 2005-03-01 at 23:11 -0800, Greg KH wrote: > You really don't want -2 for the file mode in sysfs. It creates: > -rwsrwsrwT 1 root root 4096 Mar 1 22:59 > /sys/module/radeonfb/parameters/default_dynclk > > on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please > forward

[PATCH] fix module paramater permissions in radeon_base.c

2005-03-01 Thread Greg KH
You really don't want -2 for the file mode in sysfs. It creates: -rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please forward onward as you see fit. Signed-off-by: Greg Kroah-Hartman

[PATCH] fix module paramater permissions in radeon_base.c

2005-03-01 Thread Greg KH
You really don't want -2 for the file mode in sysfs. It creates: -rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please forward onward as you see fit. Signed-off-by: Greg Kroah-Hartman

Re: [PATCH] fix module paramater permissions in radeon_base.c

2005-03-01 Thread Benjamin Herrenschmidt
On Tue, 2005-03-01 at 23:11 -0800, Greg KH wrote: You really don't want -2 for the file mode in sysfs. It creates: -rwsrwsrwT 1 root root 4096 Mar 1 22:59 /sys/module/radeonfb/parameters/default_dynclk on my box. Here's a fix against a clean 2.6.11-rc5 kernel, please forward onward