Re: [PATCH] fix plip 1

2007-11-28 Thread Mikulas Patocka
On Mon, 26 Nov 2007, Linus Torvalds wrote: > > > On Thu, 22 Nov 2007, Mikulas Patocka wrote: > > > > netif_rx is meant to be called from interrupts because it doesn't wake up > > ksoftirqd. For calling from outside interrupts, netif_rx_ni exists. > > Argh. Can you _please_ use more useful

Re: [PATCH] fix plip 1

2007-11-28 Thread Mikulas Patocka
On Mon, 26 Nov 2007, Linus Torvalds wrote: On Thu, 22 Nov 2007, Mikulas Patocka wrote: netif_rx is meant to be called from interrupts because it doesn't wake up ksoftirqd. For calling from outside interrupts, netif_rx_ni exists. Argh. Can you _please_ use more useful subject

Re: [PATCH] fix plip 1

2007-11-26 Thread Linus Torvalds
On Thu, 22 Nov 2007, Mikulas Patocka wrote: > > netif_rx is meant to be called from interrupts because it doesn't wake up > ksoftirqd. For calling from outside interrupts, netif_rx_ni exists. Argh. Can you _please_ use more useful subject lines than "fix plip 1/2"? Those subject lines are

Re: [PATCH] fix plip 1

2007-11-26 Thread Linus Torvalds
On Thu, 22 Nov 2007, Mikulas Patocka wrote: netif_rx is meant to be called from interrupts because it doesn't wake up ksoftirqd. For calling from outside interrupts, netif_rx_ni exists. Argh. Can you _please_ use more useful subject lines than fix plip 1/2? Those subject lines are what

Re: [PATCH] fix plip 1

2007-11-22 Thread Mikulas Patocka
I forgot to add: Signed-off-by: Mikulas Patocka <[EMAIL PROTECTED]> > diff -u -r linux-2.6.24-rc2/drivers/net/plip.c > linux-2.6.24-test/drivers/net/plip.c > --- linux-2.6.24-rc2/drivers/net/plip.c 2007-11-06 22:57:46.0 > +0100 > +++ linux-2.6.24-test/drivers/net/plip.c

[PATCH] fix plip 1

2007-11-22 Thread Mikulas Patocka
Hi netif_rx is meant to be called from interrupts because it doesn't wake up ksoftirqd. For calling from outside interrupts, netif_rx_ni exists. This patch fixes plip to use netif_rx_ni. It fixes the infamous error "NOHZ: local_softirq_panding 08" that happens on some machines with NOHZ and

Re: [PATCH] fix plip 1

2007-11-22 Thread Mikulas Patocka
I forgot to add: Signed-off-by: Mikulas Patocka [EMAIL PROTECTED] diff -u -r linux-2.6.24-rc2/drivers/net/plip.c linux-2.6.24-test/drivers/net/plip.c --- linux-2.6.24-rc2/drivers/net/plip.c 2007-11-06 22:57:46.0 +0100 +++ linux-2.6.24-test/drivers/net/plip.c 2007-11-22

[PATCH] fix plip 1

2007-11-22 Thread Mikulas Patocka
Hi netif_rx is meant to be called from interrupts because it doesn't wake up ksoftirqd. For calling from outside interrupts, netif_rx_ni exists. This patch fixes plip to use netif_rx_ni. It fixes the infamous error NOHZ: local_softirq_panding 08 that happens on some machines with NOHZ and