Re: [PATCH] Fixed coding style issues raised by checkpatch.

2020-10-09 Thread Joe Perches
On Fri, 2020-10-09 at 10:18 +0200, Greg Kroah-Hartman wrote: > On Fri, Oct 09, 2020 at 09:00:38AM +0100, Tabot Kevin wrote: > > This patch fixes the following: > > - Made sure alignment matched open parenthesis. > > > > Signed-off-by: Tabot Kevin > > --- > > drivers/staging/greybus/audio_module.

Re: [PATCH] Fixed coding style issues raised by checkpatch.

2020-10-09 Thread Greg Kroah-Hartman
On Fri, Oct 09, 2020 at 09:00:38AM +0100, Tabot Kevin wrote: > This patch fixes the following: > - Made sure alignment matched open parenthesis. > > Signed-off-by: Tabot Kevin > --- > drivers/staging/greybus/audio_module.c | 8 As my bot asked you to, please use scripts/get_maintainer.p

[PATCH] Fixed coding style issues raised by checkpatch.

2020-10-09 Thread Tabot Kevin
This patch fixes the following: - Made sure alignment matched open parenthesis. Signed-off-by: Tabot Kevin --- drivers/staging/greybus/audio_module.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/audio_module.c b/drivers/staging/greybus/audi

Re: [PATCH] Fixed coding style issues of xmit_linux.c

2017-02-03 Thread Greg KH
On Fri, Feb 03, 2017 at 07:49:26PM +0530, Abhijit Naik wrote: > This patch will increase readability of xmit_linux.c file. > > Removed following type of coding style warnings generated for xmit_linux.c, > 1. Braces {} are not necessary for single statement blocks > 2. Block comments us

[PATCH] Fixed coding style issues of xmit_linux.c

2017-02-03 Thread Abhijit Naik
This patch will increase readability of xmit_linux.c file. Removed following type of coding style warnings generated for xmit_linux.c, 1. Braces {} are not necessary for single statement blocks 2. Block comments use a trailing */ on a separate line Signed-off-by: Abhijit Naik ---

Re: [PATCH] Fixed coding style issues at ieee80211_crypt_wep.c

2015-05-18 Thread pmarzo
On Mon, 2015-05-18 at 11:33 +0300, Dan Carpenter wrote: > Also the use a subsystem prefix in the subject: > > [PATCH] Staging: rtl8192u: whatever... > > > regards, > dan carpenter > Thanku for your comments, I will send an v2 patch version regards, Pedro -- To unsubscribe from this list: send

Re: [PATCH] Fixed coding style issues at ieee80211_crypt_wep.c

2015-05-18 Thread Dan Carpenter
Also the use a subsystem prefix in the subject: [PATCH] Staging: rtl8192u: whatever... regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] Fixed coding style issues at ieee80211_crypt_wep.c

2015-05-15 Thread Joe Perches
On Sat, 2015-05-16 at 10:40 +0200, Pedro Marzo Perez wrote: > This patch just fixes some warnings and style errors reported by > checkpatch.pl script > - Braces should not start in a new line > - C99 comments are not allowed (never use //) > - Literal strings should never be parted in

[PATCH] Fixed coding style issues at ieee80211_crypt_wep.c

2015-05-15 Thread Pedro Marzo Perez
This patch just fixes some warnings and style errors reported by checkpatch.pl script - Braces should not start in a new line - C99 comments are not allowed (never use //) - Literal strings should never be parted in several lines - There was a useless return on a void function Sig

Re: [PATCH] fixed coding style issues

2012-07-29 Thread Dmitry Torokhov
Hi Baodong, On Wed, Jul 25, 2012 at 03:11:17PM +0800, Baodong Chen wrote: > Fexed coding style issues from scripts/checkpatch.pl in drivers/input > Thank you for your patch. I picked up the parts that made sense and dropped the rest. Thanks. -- Dmitry -- To unsubscribe from this list: send th

Re: [PATCH] fixed coding style issues

2012-07-25 Thread Baodong Chen
On Wed, Jul 25, 2012 at 4:01 PM, Joe Perches wrote: > On Wed, 2012-07-25 at 15:44 +0800, Baodong Chen wrote: >> i want to participate in and to start from >> fixing simple issues! > > That's fine Baodong. Welcome. > >> how could i choose issues form checkpatch's output to find which >> should be

Re: [PATCH] fixed coding style issues

2012-07-25 Thread Joe Perches
On Wed, 2012-07-25 at 15:44 +0800, Baodong Chen wrote: > i want to participate in and to start from > fixing simple issues! That's fine Baodong. Welcome. > how could i choose issues form checkpatch's output to find which > should be fixed which are > not? checkpatch output is merely a guide for

Re: [PATCH] fixed coding style issues

2012-07-25 Thread Baodong Chen
i want to participate in and to start from fixing simple issues! how could i choose issues form checkpatch's output to find which should be fixed which are not? or checkpatch.pl should be updated?? On Wed, Jul 25, 2012 at 3:30 PM, Joe Perches wrote: > On Wed, 2012-07-25 at 15:11 +0800, Baodong Ch

Re: [PATCH] fixed coding style issues

2012-07-25 Thread Joe Perches
On Wed, 2012-07-25 at 15:11 +0800, Baodong Chen wrote: > Fexed coding style issues from scripts/checkpatch.pl in drivers/input Not all checkpatch messages need to be "fexed". :) Please use some taste and judgment before submitting patches based solely on checkpatch output. > diff --git a/drivers

[PATCH] fixed coding style issues

2012-07-25 Thread Baodong Chen
Fexed coding style issues from scripts/checkpatch.pl in drivers/input Signed-off-by: Baodong Chen --- drivers/input/apm-power.c |2 +- drivers/input/evdev.c | 52 +++- drivers/input/ff-core.c |4 +- drivers/input/ff-memless.c|