Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-29 Thread Arnd Bergmann
On Wed, Apr 29, 2020 at 1:53 PM Christoph Hellwig wrote: > > I did another pass at this, reducing the overhead of the x32 magic > in common code down to renaming copy_siginfo_to_user32 to > copy_siginfo_to_user32 and having a conditional #define to give it > the old name back: Nice! I guess this

Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-29 Thread Christoph Hellwig
I did another pass at this, reducing the overhead of the x32 magic in common code down to renaming copy_siginfo_to_user32 to copy_siginfo_to_user32 and having a conditional #define to give it the old name back: --- >From 45e5263d7c24d854bb446b7e69dc53729ed842bc Mon Sep 17 00:00:00 2001 From: Chris

Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-29 Thread Arnd Bergmann
On Wed, Apr 29, 2020 at 11:42 AM Christoph Hellwig wrote: > > On Wed, Apr 29, 2020 at 10:07:11AM +0200, Arnd Bergmann wrote: > > > What do you think of this version? This one always overrides > > > copy_siginfo_to_user32 for the x86 compat case to keep the churn down, > > > and improves the copy_

Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-29 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 10:07:11AM +0200, Arnd Bergmann wrote: > > What do you think of this version? This one always overrides > > copy_siginfo_to_user32 for the x86 compat case to keep the churn down, > > and improves the copy_siginfo_to_external32 documentation a bit. > > Looks good to me. I p

Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-29 Thread Arnd Bergmann
On Wed, Apr 29, 2020 at 8:45 AM Christoph Hellwig wrote: > > On Tue, Apr 28, 2020 at 09:56:26PM +0200, Arnd Bergmann wrote: > > I think I found a way to improve the x32 handling: > > > > This is a simplification over Christoph's "[PATCH 2/7] signal: factor > > copy_siginfo_to_external32 from copy_

Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-28 Thread Christoph Hellwig
On Tue, Apr 28, 2020 at 09:56:26PM +0200, Arnd Bergmann wrote: > I think I found a way to improve the x32 handling: > > This is a simplification over Christoph's "[PATCH 2/7] signal: factor > copy_siginfo_to_external32 from copy_siginfo_to_user32", reducing the > x32 specifics in the common code t

Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-28 Thread Christoph Hellwig
On Wed, Apr 29, 2020 at 08:17:22AM +0200, Christophe Leroy wrote: >> +#ifndef CONFIG_X86_X32_ABI > > Can it be declared __weak instead of enclosing it in an #ifndef ? I really hate the __weak ifdefs. But my plan was to move to a CONFIG_ARCH_COPY_SIGINFO_TO_USER32 and have x86 select it.

Re: [PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-28 Thread Christophe Leroy
Le 28/04/2020 à 21:56, Arnd Bergmann a écrit : I think I found a way to improve the x32 handling: This is a simplification over Christoph's "[PATCH 2/7] signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32", reducing the x32 specifics in the common code to a single #ifdef/#en

[PATCH] fixup! signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32

2020-04-28 Thread Arnd Bergmann
I think I found a way to improve the x32 handling: This is a simplification over Christoph's "[PATCH 2/7] signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32", reducing the x32 specifics in the common code to a single #ifdef/#endif check, in order to keep it more readable for eve