Re: [PATCH] flush cache fixes for ia64 [2/2] sync icache dcache

2007-07-27 Thread KAMEZAWA Hiroyuki
On Sat, 28 Jul 2007 00:02:23 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > On Fri, 27 Jul 2007 16:16:27 +0200 > Zoltan Menyhart <[EMAIL PROTECTED]> wrote: > > > Do you really need a "sync_icache_dcache()" in "do_wp_page()"? > > I guess it is only needed when the EXEC bit of the PTE gets tu

Re: [PATCH] flush cache fixes for ia64 [2/2] sync icache dcache

2007-07-27 Thread KAMEZAWA Hiroyuki
On Fri, 27 Jul 2007 16:16:27 +0200 Zoltan Menyhart <[EMAIL PROTECTED]> wrote: > Do you really need a "sync_icache_dcache()" in "do_wp_page()"? > I guess it is only needed when the EXEC bit of the PTE gets turned on. > Ah, sorry. do_wp_page() without page copy (reuse case) doesn't need sync. Abou

Re: [PATCH] flush cache fixes for ia64 [2/2] sync icache dcache

2007-07-27 Thread Zoltan Menyhart
Do you really need a "sync_icache_dcache()" in "do_wp_page()"? I guess it is only needed when the EXEC bit of the PTE gets turned on. --- linux-2.6.23-rc1.test.orig/mm/migrate.c +++ linux-2.6.23-rc1.test/mm/migrate.c @@ -172,6 +172,7 @@ static void remove_migration_pte(struct pte = pte_mkold(

[PATCH] flush cache fixes for ia64 [2/2] sync icache dcache

2007-07-26 Thread KAMEZAWA Hiroyuki
flush icache for ia64 take4. This patch is against 2.6.23-rc1. Changes v3 -> v4: - avoid implementing flush_(i)cache_pages(). - added sync_icache_dcache() call. - change Documentation/cachetlb.txt Current ia64 kernel flushes icache by lazy_mmu_prot_update() *after* set_pte(). This is wrong.