Re: [PATCH] fork: fix error handling in dup_task()

2012-07-13 Thread Chris Metcalf
On 7/13/2012 6:07 AM, Akinobu Mita wrote: > 2012/7/13 Andrew Morton : >> On Thu, 12 Jul 2012 20:04:53 +0900 >> Akinobu Mita wrote: >> >>> The function dup_task() may fail at the following function calls in >>> the following order. >>> >>> 0) alloc_task_struct_node() >>> 1)

Re: [PATCH] fork: fix error handling in dup_task()

2012-07-13 Thread Akinobu Mita
2012/7/13 Andrew Morton : > On Thu, 12 Jul 2012 20:04:53 +0900 > Akinobu Mita wrote: > >> The function dup_task() may fail at the following function calls in >> the following order. >> >> 0) alloc_task_struct_node() >> 1) alloc_thread_info_node() >> 2) arch_dup_task_struct() >> >> Error by 0) is

Re: [PATCH] fork: fix error handling in dup_task()

2012-07-13 Thread Akinobu Mita
2012/7/13 Andrew Morton a...@linux-foundation.org: On Thu, 12 Jul 2012 20:04:53 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: The function dup_task() may fail at the following function calls in the following order. 0) alloc_task_struct_node() 1) alloc_thread_info_node() 2)

Re: [PATCH] fork: fix error handling in dup_task()

2012-07-13 Thread Chris Metcalf
On 7/13/2012 6:07 AM, Akinobu Mita wrote: 2012/7/13 Andrew Morton a...@linux-foundation.org: On Thu, 12 Jul 2012 20:04:53 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: The function dup_task() may fail at the following function calls in the following order. 0) alloc_task_struct_node()

Re: [PATCH] fork: fix error handling in dup_task()

2012-07-12 Thread Andrew Morton
On Thu, 12 Jul 2012 20:04:53 +0900 Akinobu Mita wrote: > The function dup_task() may fail at the following function calls in > the following order. > > 0) alloc_task_struct_node() > 1) alloc_thread_info_node() > 2) arch_dup_task_struct() > > Error by 0) is not a matter, it can just return.

[PATCH] fork: fix error handling in dup_task()

2012-07-12 Thread Akinobu Mita
The function dup_task() may fail at the following function calls in the following order. 0) alloc_task_struct_node() 1) alloc_thread_info_node() 2) arch_dup_task_struct() Error by 0) is not a matter, it can just return. But error by 1) requires releasing task_struct allocated by 0) before it

[PATCH] fork: fix error handling in dup_task()

2012-07-12 Thread Akinobu Mita
The function dup_task() may fail at the following function calls in the following order. 0) alloc_task_struct_node() 1) alloc_thread_info_node() 2) arch_dup_task_struct() Error by 0) is not a matter, it can just return. But error by 1) requires releasing task_struct allocated by 0) before it

Re: [PATCH] fork: fix error handling in dup_task()

2012-07-12 Thread Andrew Morton
On Thu, 12 Jul 2012 20:04:53 +0900 Akinobu Mita akinobu.m...@gmail.com wrote: The function dup_task() may fail at the following function calls in the following order. 0) alloc_task_struct_node() 1) alloc_thread_info_node() 2) arch_dup_task_struct() Error by 0) is not a matter, it can