Re: [PATCH] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-19 Thread John Hubbard
On 2020-05-19 08:10, Xu Yilun wrote: ... @@ -72,7 +63,7 @@ static int afu_dma_pin_pages(struct dfl_feature_platform_data *pdata, return 0; put_pages: How about we also change the tag to "unpin_pages"? Others look good to me. Sure, I'll send a v2 with that. thanks, -- John Hu

Re: [PATCH] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-19 Thread Xu Yilun
On Sat, May 16, 2020 at 06:18:37PM -0700, John Hubbard wrote: > This code was using get_user_pages_fast(), in a "Case 2" scenario > (DMA/RDMA), using the categorization from [1]. That means that it's > time to convert the get_user_pages_fast() + put_page() calls to > pin_user_pages_fast() + unpin_u

[PATCH] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-16 Thread John Hubbard
This code was using get_user_pages_fast(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to convert the get_user_pages_fast() + put_page() calls to pin_user_pages_fast() + unpin_user_pages() calls. There is some helpful background in [2]: basically