Re: [PATCH] fpga: dfl: fme: Constify static attribute_group structs

2021-01-10 Thread Moritz Fischer
On Sat, Jan 09, 2021 at 05:40:38PM -0800, Tom Rix wrote: > > On 1/9/21 2:52 PM, Rikard Falkeborn wrote: > > On Sat, Jan 09, 2021 at 01:55:13PM -0800, Tom Rix wrote: > >> On 1/8/21 3:54 PM, Rikard Falkeborn wrote: > >>> The only usage of these is to put their addresses in arrays of pointers > >>>

Re: [PATCH] fpga: dfl: fme: Constify static attribute_group structs

2021-01-09 Thread Tom Rix
On 1/9/21 2:52 PM, Rikard Falkeborn wrote: > On Sat, Jan 09, 2021 at 01:55:13PM -0800, Tom Rix wrote: >> On 1/8/21 3:54 PM, Rikard Falkeborn wrote: >>> The only usage of these is to put their addresses in arrays of pointers >>> to const attribute_groups. Make them const to allow the compiler to

Re: [PATCH] fpga: dfl: fme: Constify static attribute_group structs

2021-01-09 Thread Rikard Falkeborn
On Sat, Jan 09, 2021 at 01:55:13PM -0800, Tom Rix wrote: > > On 1/8/21 3:54 PM, Rikard Falkeborn wrote: > > The only usage of these is to put their addresses in arrays of pointers > > to const attribute_groups. Make them const to allow the compiler to put > > them in read-only memory. > > > >

Re: [PATCH] fpga: dfl: fme: Constify static attribute_group structs

2021-01-09 Thread Tom Rix
On 1/8/21 3:54 PM, Rikard Falkeborn wrote: > The only usage of these is to put their addresses in arrays of pointers > to const attribute_groups. Make them const to allow the compiler to put > them in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > drivers/fpga/dfl-fme-perf.c | 6

[PATCH] fpga: dfl: fme: Constify static attribute_group structs

2021-01-08 Thread Rikard Falkeborn
The only usage of these is to put their addresses in arrays of pointers to const attribute_groups. Make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- drivers/fpga/dfl-fme-perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)