Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-30 Thread Gustavo A. R. Silva
Hi Alan, Quoting Alan Tull : On Sat, Oct 28, 2017 at 12:15 PM, Moritz Fischer wrote: Hi Gustavo, Thanks! Glad to help. :) Thanks -- Gustavo A. R. Silva

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-30 Thread Alan Tull
On Sat, Oct 28, 2017 at 12:15 PM, Moritz Fischer wrote: Hi Gustavo, Thanks! Alan > On Fri, Oct 27, 2017 at 08:19:51PM +, Gustavo A. R. Silva wrote: >> Notice that bridge = to_fpga_bridge(dev); expands to: >> >> bridge = container_of(dev, struct fpga_bridge, dev); >> >> and container_of is

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-28 Thread Gustavo A. R. Silva
Hi Moritz, Quoting Moritz Fischer : On Fri, Oct 27, 2017 at 08:19:51PM +, Gustavo A. R. Silva wrote: Notice that bridge = to_fpga_bridge(dev); expands to: bridge = container_of(dev, struct fpga_bridge, dev); and container_of is never null, so this null check is unnecessary. Addresses-Co

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-28 Thread Moritz Fischer
On Fri, Oct 27, 2017 at 08:19:51PM +, Gustavo A. R. Silva wrote: > Notice that bridge = to_fpga_bridge(dev); expands to: > > bridge = container_of(dev, struct fpga_bridge, dev); > > and container_of is never null, so this null check is > unnecessary. > > Addresses-Coverity-ID: 1397912 > Repo

[PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-27 Thread Gustavo A. R. Silva
Notice that bridge = to_fpga_bridge(dev); expands to: bridge = container_of(dev, struct fpga_bridge, dev); and container_of is never null, so this null check is unnecessary. Addresses-Coverity-ID: 1397912 Reported-by: Alan Tull Signed-off-by: Gustavo A. R. Silva --- drivers/fpga/fpga-bridge.c