Re: [PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Moritz Fischer
On Tue, Apr 11, 2017 at 09:53:38AM -0500, Alan Tull wrote: > On Tue, Apr 11, 2017 at 4:22 AM, Tobias Klauser wrote: > > Hi Tobias, > > Thanks! > > > If either _alt_hps2fpga_enable_set() or fpga_bridge_register() fail in > > alt_fpga_bridge_probe(), the clock remains

Re: [PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Moritz Fischer
On Tue, Apr 11, 2017 at 09:53:38AM -0500, Alan Tull wrote: > On Tue, Apr 11, 2017 at 4:22 AM, Tobias Klauser wrote: > > Hi Tobias, > > Thanks! > > > If either _alt_hps2fpga_enable_set() or fpga_bridge_register() fail in > > alt_fpga_bridge_probe(), the clock remains enabled and prepared. Also,

Re: [PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Alan Tull
On Tue, Apr 11, 2017 at 4:22 AM, Tobias Klauser wrote: Hi Tobias, Thanks! > If either _alt_hps2fpga_enable_set() or fpga_bridge_register() fail in > alt_fpga_bridge_probe(), the clock remains enabled and prepared. Also, > in the error path for _alt_hps2fpga_enable_set() a

Re: [PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Alan Tull
On Tue, Apr 11, 2017 at 4:22 AM, Tobias Klauser wrote: Hi Tobias, Thanks! > If either _alt_hps2fpga_enable_set() or fpga_bridge_register() fail in > alt_fpga_bridge_probe(), the clock remains enabled and prepared. Also, > in the error path for _alt_hps2fpga_enable_set() a call to >

[PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Tobias Klauser
If either _alt_hps2fpga_enable_set() or fpga_bridge_register() fail in alt_fpga_bridge_probe(), the clock remains enabled and prepared. Also, in the error path for _alt_hps2fpga_enable_set() a call to fpga_bridge_unregister() is made even though the bridge was not registered yet. Remove the

[PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Tobias Klauser
If either _alt_hps2fpga_enable_set() or fpga_bridge_register() fail in alt_fpga_bridge_probe(), the clock remains enabled and prepared. Also, in the error path for _alt_hps2fpga_enable_set() a call to fpga_bridge_unregister() is made even though the bridge was not registered yet. Remove the