Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 3:25 PM, wrote: >> Maybe you actually wanna bail out if you read a random other value >> instead of what you >> expect instead of printing a warning. > > > I thought about making it an error if the version didn't match, but it

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 3:25 PM, wrote: >> Maybe you actually wanna bail out if you read a random other value >> instead of what you >> expect instead of printing a warning. > > > I thought about making it an error if the version didn't match, but it was a > dev_warn() before and

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread matthew . gerlach
On Wed, 5 Apr 2017, Moritz Fischer wrote: Hi Matthew, Hi Moritz, On Wed, Apr 5, 2017 at 12:05 PM, wrote: From: Matthew Gerlach The value in the version register of the altera freeze bridge controller changed from the

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread matthew . gerlach
On Wed, 5 Apr 2017, Moritz Fischer wrote: Hi Matthew, Hi Moritz, On Wed, Apr 5, 2017 at 12:05 PM, wrote: From: Matthew Gerlach The value in the version register of the altera freeze bridge controller changed from the beta value of 2 to the value of 0xad03 in the official

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 12:05 PM, wrote: > From: Matthew Gerlach > > The value in the version register of the altera freeze bridge > controller changed from the beta value of 2 to the > value of 0xad03 in the

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 12:05 PM, wrote: > From: Matthew Gerlach > > The value in the version register of the altera freeze bridge > controller changed from the beta value of 2 to the > value of 0xad03 in the official release of the IP. > This patch supports the old and new

[PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread matthew . gerlach
From: Matthew Gerlach The value in the version register of the altera freeze bridge controller changed from the beta value of 2 to the value of 0xad03 in the official release of the IP. This patch supports the old and new version numbers without printing an

[PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread matthew . gerlach
From: Matthew Gerlach The value in the version register of the altera freeze bridge controller changed from the beta value of 2 to the value of 0xad03 in the official release of the IP. This patch supports the old and new version numbers without printing an warning. Signed-off-by: Matthew