Re: [PATCH] fs, elf: Make sure to page align bss in load_elf_library

2018-07-06 Thread Andrew Morton
On Thu, 5 Jul 2018 08:44:18 -0700 Kees Cook wrote: > On Thu, Jul 5, 2018 at 7:55 AM, wrote: > > From: Oscar Salvador > > > > The current code does not make sure to page align bss before calling > > vm_brk(), and this can lead to a VM_BUG_ON() in __mm_populate() > > due to the requested lenght

Re: [PATCH] fs, elf: Make sure to page align bss in load_elf_library

2018-07-06 Thread Kees Cook
On Fri, Jul 6, 2018 at 12:13 AM, Oscar Salvador wrote: > On Thu, Jul 05, 2018 at 08:44:18AM -0700, Kees Cook wrote: >> On Thu, Jul 5, 2018 at 7:55 AM, wrote: >> > From: Oscar Salvador >> > >> > The current code does not make sure to page align bss before calling >> > vm_brk(), and this can lead

Re: [PATCH] fs, elf: Make sure to page align bss in load_elf_library

2018-07-06 Thread Oscar Salvador
On Thu, Jul 05, 2018 at 08:44:18AM -0700, Kees Cook wrote: > On Thu, Jul 5, 2018 at 7:55 AM, wrote: > > From: Oscar Salvador > > > > The current code does not make sure to page align bss before calling > > vm_brk(), and this can lead to a VM_BUG_ON() in __mm_populate() > > due to the requested l

Re: [PATCH] fs, elf: Make sure to page align bss in load_elf_library

2018-07-05 Thread Kees Cook
On Thu, Jul 5, 2018 at 7:55 AM, wrote: > From: Oscar Salvador > > The current code does not make sure to page align bss before calling > vm_brk(), and this can lead to a VM_BUG_ON() in __mm_populate() > due to the requested lenght not being correctly aligned. > > Let us make sure to align it pro

[PATCH] fs, elf: Make sure to page align bss in load_elf_library

2018-07-05 Thread osalvador
From: Oscar Salvador The current code does not make sure to page align bss before calling vm_brk(), and this can lead to a VM_BUG_ON() in __mm_populate() due to the requested lenght not being correctly aligned. Let us make sure to align it properly. Signed-off-by: Oscar Salvador Tested-by: Tet