Re: [PATCH] fs/dcache.c: revamped to use a more straightforward and efficient way to operate

Hello, thanks for the patch. I have a few comments to it: 1) the patch should have a description in it, not only an email subject 2) usually, if an 'if' branch ends with return, as is the case in your patch, we don't use 'else' for the other branch... BTW: I'm not convinced your code would

[PATCH] fs/dcache.c: revamped to use a more straightforward and efficient way to operate

Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- fs/dcache.c | 39 ++- 1 files changed, 18 insertions(+), 21 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index 678d39d..05ed44a 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1138,29 +1138,26 @@ struct