Re: [PATCH] fs/devpts: always delete dcache dentry-s in dput()

On Thu, Jan 24, 2019 at 02:03:06PM +0100, v...@amazon.com wrote: > diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c > index c538145..553a3f3 100644 > --- a/fs/devpts/inode.c > +++ b/fs/devpts/inode.c > @@ -455,6 +455,7 @@ devpts_fill_super(struct super_block *s, void *data, int > silent) >

[PATCH] fs/devpts: always delete dcache dentry-s in dput()

From: Varad Gautam d_delete only unhashes an entry if it is reached with dentry->d_lockref.count != 1. Prior to commit 8ead9dd54716 ("devpts: more pty driver interface cleanups"), d_delete was called on a dentry from devpts_pty_kill with two references held, which would trigger the unhashing,