Re: [PATCH] fs/file.c: tidy up close_files

2015-10-08 Thread kbuild test robot
Hi Mateusz, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) fs/file.c:321:17: sparse: incor

[PATCH] fs/file.c: tidy up close_files

2015-10-08 Thread Mateusz Guzik
Improve consistency by reorganizing the code to use the same constructs as do_close_on_exec. Get rid of xchg of the file pointer. Since the table is about to be freed there is no reason to NULLify the slot. Get rid of the file NULL check. At this stage a bit set is supposed to guarantee the slot