Re: [PATCH] fs/userfaultfd.c: simplify the calculation of new_flags

2019-10-08 Thread Peter Xu
On Fri, Oct 04, 2019 at 07:28:34PM -0400, Andrea Arcangeli wrote: > On Sat, Oct 05, 2019 at 06:46:40AM +0800, Wei Yang wrote: > > On Wed, Oct 02, 2019 at 08:45:05PM -0400, Andrea Arcangeli wrote: > > >Hello, > > > > > >On Tue, Aug 06, 2019 at 01:38:59PM +0800, Wei Yang wrote: > > >> Finally

Re: [PATCH] fs/userfaultfd.c: simplify the calculation of new_flags

2019-10-04 Thread Wei Yang
On Fri, Oct 04, 2019 at 07:28:34PM -0400, Andrea Arcangeli wrote: >On Sat, Oct 05, 2019 at 06:46:40AM +0800, Wei Yang wrote: >> On Wed, Oct 02, 2019 at 08:45:05PM -0400, Andrea Arcangeli wrote: >> >Hello, >> > >> >On Tue, Aug 06, 2019 at 01:38:59PM +0800, Wei Yang wrote: >> >> Finally new_flags

Re: [PATCH] fs/userfaultfd.c: simplify the calculation of new_flags

2019-10-04 Thread Andrea Arcangeli
On Sat, Oct 05, 2019 at 06:46:40AM +0800, Wei Yang wrote: > On Wed, Oct 02, 2019 at 08:45:05PM -0400, Andrea Arcangeli wrote: > >Hello, > > > >On Tue, Aug 06, 2019 at 01:38:59PM +0800, Wei Yang wrote: > >> Finally new_flags equals old vm_flags *OR* vm_flags. > >> > >> It is not necessary to mask

Re: [PATCH] fs/userfaultfd.c: simplify the calculation of new_flags

2019-10-04 Thread Wei Yang
On Wed, Oct 02, 2019 at 08:45:05PM -0400, Andrea Arcangeli wrote: >Hello, > >On Tue, Aug 06, 2019 at 01:38:59PM +0800, Wei Yang wrote: >> Finally new_flags equals old vm_flags *OR* vm_flags. >> >> It is not necessary to mask them first. >> >> Signed-off-by: Wei Yang >> --- >> fs/userfaultfd.c

Re: [PATCH] fs/userfaultfd.c: simplify the calculation of new_flags

2019-10-02 Thread Andrea Arcangeli
Hello, On Tue, Aug 06, 2019 at 01:38:59PM +0800, Wei Yang wrote: > Finally new_flags equals old vm_flags *OR* vm_flags. > > It is not necessary to mask them first. > > Signed-off-by: Wei Yang > --- > fs/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] fs/userfaultfd.c: simplify the calculation of new_flags

2019-09-11 Thread Wei Yang
Ping~ On Tue, Aug 06, 2019 at 01:38:59PM +0800, Wei Yang wrote: >Finally new_flags equals old vm_flags *OR* vm_flags. > >It is not necessary to mask them first. > >Signed-off-by: Wei Yang >--- > fs/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git

[PATCH] fs/userfaultfd.c: simplify the calculation of new_flags

2019-08-05 Thread Wei Yang
Finally new_flags equals old vm_flags *OR* vm_flags. It is not necessary to mask them first. Signed-off-by: Wei Yang --- fs/userfaultfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c index ccbdbd62f0d8..653d8f7c453c 100644 ---