Re: [PATCH] fs/vfs: improve __mnt_is_readonly

2016-03-30 Thread Richard Weinberger
Am 30.03.2016 um 03:23 schrieb Yaowei Bai: > On Tue, Mar 29, 2016 at 11:43:21AM +0200, Richard Weinberger wrote: >> On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai >> wrote: >>> On Sat, Mar 26, 2016 at 12:43:32AM +, Al Viro wrote: On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote: >>

Re: [PATCH] fs/vfs: improve __mnt_is_readonly

2016-03-29 Thread Yaowei Bai
On Tue, Mar 29, 2016 at 11:43:21AM +0200, Richard Weinberger wrote: > On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai > wrote: > > On Sat, Mar 26, 2016 at 12:43:32AM +, Al Viro wrote: > >> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote: > >> > This patch refactors __mnt_is_readonly and

Re: [PATCH] fs/vfs: improve __mnt_is_readonly

2016-03-29 Thread Richard Weinberger
On Tue, Mar 29, 2016 at 8:35 AM, Yaowei Bai wrote: > On Sat, Mar 26, 2016 at 12:43:32AM +, Al Viro wrote: >> On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote: >> > This patch refactors __mnt_is_readonly and makes it return bool to >> > improve readability due to this particular funct

Re: [PATCH] fs/vfs: improve __mnt_is_readonly

2016-03-28 Thread Yaowei Bai
On Sat, Mar 26, 2016 at 12:43:32AM +, Al Viro wrote: > On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote: > > This patch refactors __mnt_is_readonly and makes it return bool to > > improve readability due to this particular function only using either > > one or zero as its return value

Re: [PATCH] fs/vfs: improve __mnt_is_readonly

2016-03-25 Thread Al Viro
On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote: > This patch refactors __mnt_is_readonly and makes it return bool to > improve readability due to this particular function only using either > one or zero as its return value. Improve in which way, if I may ask?

[PATCH] fs/vfs: improve __mnt_is_readonly

2016-03-24 Thread Yaowei Bai
This patch refactors __mnt_is_readonly and makes it return bool to improve readability due to this particular function only using either one or zero as its return value. No functional change. Signed-off-by: Yaowei Bai --- fs/namespace.c| 9 +++-- include/linux/mount.h | 2 +- 2 file