Re: [PATCH] fs: Handle register_shrinker failure

2017-04-27 Thread Al Viro
On Fri, Apr 28, 2017 at 05:30:46AM +0100, Al Viro wrote: > I really don't like that. Your "remove it from all lists and pray that > nobody has picked a reference of any kind" at the very least needs a careful > written proof of correctness. AFAICS, somebody might've found it on the > list and

Re: [PATCH] fs: Handle register_shrinker failure

2017-04-27 Thread Al Viro
On Fri, Apr 28, 2017 at 05:30:46AM +0100, Al Viro wrote: > I really don't like that. Your "remove it from all lists and pray that > nobody has picked a reference of any kind" at the very least needs a careful > written proof of correctness. AFAICS, somebody might've found it on the > list and

Re: [PATCH] fs: Handle register_shrinker failure

2017-04-27 Thread Al Viro
On Fri, Mar 24, 2017 at 09:55:40AM +0200, Nikolay Borisov wrote: > register_shrinker allocates dynamic memory and thus is susceptible to failures > under low-memory situation. Currently,get_userns ignores the return value of > register_shrinker, potentially exposing not fully initialised object.

Re: [PATCH] fs: Handle register_shrinker failure

2017-04-27 Thread Al Viro
On Fri, Mar 24, 2017 at 09:55:40AM +0200, Nikolay Borisov wrote: > register_shrinker allocates dynamic memory and thus is susceptible to failures > under low-memory situation. Currently,get_userns ignores the return value of > register_shrinker, potentially exposing not fully initialised object.

Re: [PATCH] fs: Handle register_shrinker failure

2017-04-06 Thread Goldwyn Rodrigues
On 03/24/2017 02:55 AM, Nikolay Borisov wrote: > register_shrinker allocates dynamic memory and thus is susceptible to failures > under low-memory situation. Currently,get_userns ignores the return value of > register_shrinker, potentially exposing not fully initialised object. This > can lead

Re: [PATCH] fs: Handle register_shrinker failure

2017-04-06 Thread Goldwyn Rodrigues
On 03/24/2017 02:55 AM, Nikolay Borisov wrote: > register_shrinker allocates dynamic memory and thus is susceptible to failures > under low-memory situation. Currently,get_userns ignores the return value of > register_shrinker, potentially exposing not fully initialised object. This > can lead

[PATCH] fs: Handle register_shrinker failure

2017-03-24 Thread Nikolay Borisov
register_shrinker allocates dynamic memory and thus is susceptible to failures under low-memory situation. Currently,get_userns ignores the return value of register_shrinker, potentially exposing not fully initialised object. This can lead to a NULL-ptr deref everytime shrinker->nr_deferred is

[PATCH] fs: Handle register_shrinker failure

2017-03-24 Thread Nikolay Borisov
register_shrinker allocates dynamic memory and thus is susceptible to failures under low-memory situation. Currently,get_userns ignores the return value of register_shrinker, potentially exposing not fully initialised object. This can lead to a NULL-ptr deref everytime shrinker->nr_deferred is

[PATCH] fs: Handle register_shrinker failure

2017-03-24 Thread Nikolay Borisov
register_shrinker allocates dynamic memory and thus is susceptible to failures under low-memory situation. Currently,get_userns ignores the return value of register_shrinker, potentially exposing not fully initialised object. This can lead to a NULL-ptr deref everytime shrinker->nr_deferred is

[PATCH] fs: Handle register_shrinker failure

2017-03-24 Thread Nikolay Borisov
register_shrinker allocates dynamic memory and thus is susceptible to failures under low-memory situation. Currently,get_userns ignores the return value of register_shrinker, potentially exposing not fully initialised object. This can lead to a NULL-ptr deref everytime shrinker->nr_deferred is