Re: [PATCH] fs: Improve eventpoll logging to stop indicting timerfd

2021-03-25 Thread Thomas Gleixner
Manish, On Wed, Mar 24 2021 at 22:18, Manish Varma wrote: > On Mon, Mar 22, 2021 at 2:40 PM Thomas Gleixner wrote: >> >> Not that I expect any real dependencies on it, but as always the devil >> is in the details. > > Right, there are some userspace which depends on "[timerfd]" string > https://c

Re: [PATCH] fs: Improve eventpoll logging to stop indicting timerfd

2021-03-24 Thread Manish Varma
Hi Thomas, On Mon, Mar 22, 2021 at 2:40 PM Thomas Gleixner wrote: > > Manish, > > On Mon, Mar 22 2021 at 10:15, Manish Varma wrote: > > On Thu, Mar 18, 2021 at 6:04 AM Thomas Gleixner wrote: > >> > +static atomic_t instance_count = ATOMIC_INIT(0); > >> > >> instance_count is misleading as it doe

Re: [PATCH] fs: Improve eventpoll logging to stop indicting timerfd

2021-03-22 Thread Thomas Gleixner
Manish, On Mon, Mar 22 2021 at 10:15, Manish Varma wrote: > On Thu, Mar 18, 2021 at 6:04 AM Thomas Gleixner wrote: >> > +static atomic_t instance_count = ATOMIC_INIT(0); >> >> instance_count is misleading as it does not do any accounting of >> instances as the name suggests. >> > > Not sure if I

Re: [PATCH] fs: Improve eventpoll logging to stop indicting timerfd

2021-03-22 Thread Manish Varma
Hi Thomas, On Thu, Mar 18, 2021 at 6:04 AM Thomas Gleixner wrote: > > Manish, > > On Mon, Mar 01 2021 at 19:49, Manish Varma wrote: > > > All together, that will give us names like the following: > > > > 1) timerfd file descriptor: [timerfd14:system_server] > > 2) eventpoll top-level per-process

Re: [PATCH] fs: Improve eventpoll logging to stop indicting timerfd

2021-03-18 Thread Thomas Gleixner
Manish, On Mon, Mar 01 2021 at 19:49, Manish Varma wrote: > All together, that will give us names like the following: > > 1) timerfd file descriptor: [timerfd14:system_server] > 2) eventpoll top-level per-process wakesource: epoll:system_server > 3) eventpoll-on-timerfd per-descriptor wakesource:

[PATCH] fs: Improve eventpoll logging to stop indicting timerfd

2021-03-02 Thread Manish Varma
timerfd doesn't create any wakelocks, but eventpoll can. When it does, it names them after the underlying file descriptor, and since all timerfd file descriptors are named "[timerfd]" (which saves memory on systems like desktops with potentially many timerfd instances), all wakesources created as