Re: [PATCH] fs: affs: fix a NULL pointer dereference

2019-03-21 Thread David Sterba
On Fri, Mar 15, 2019 at 02:42:44AM -0500, Kangjie Lu wrote: > If affs_bread fails, do not use ext_bh to avoid NULL pointer > dereference > > Signed-off-by: Kangjie Lu Tanks for the patch. I'll need some more time to get familiar with the AFFS code to review your patch.

Re: [PATCH] fs: affs: fix a NULL pointer dereference

2019-03-19 Thread Geert Uytterhoeven
Hi Kangjie, On Thu, Mar 14, 2019 at 8:47 AM Kangjie Lu wrote: > If affs_bread fails, do not use ext_bh to avoid NULL pointer > dereference > > Signed-off-by: Kangjie Lu Thanks for your patch! > --- a/fs/affs/file.c > +++ b/fs/affs/file.c > @@ -835,7 +835,7 @@ void > affs_truncate(struct inod

Re: [PATCH] fs: affs: fix a NULL pointer dereference

2019-03-19 Thread Dan Carpenter
Hi Kangjie, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Kangjie-Lu/fs-affs-fix-a-NULL-pointer-dereference/20190314-170334 New smatch warnings: fs/affs/file.c:951 affs_truncate() error: we previously assumed 'ext_bh' could be null (see

[PATCH] fs: affs: fix a NULL pointer dereference

2019-03-15 Thread Kangjie Lu
If affs_bread fails, do not use ext_bh to avoid NULL pointer dereference Signed-off-by: Kangjie Lu --- fs/affs/file.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index a85817f54483..29cbc8eda085 100644 --- a/fs/affs/file.c +++ b/fs/a

Re: [PATCH] fs: affs: fix a NULL pointer dereference

2019-03-14 Thread kbuild test robot
Hi Kangjie, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0 next-20190306] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/lin

[PATCH] fs: affs: fix a NULL pointer dereference

2019-03-14 Thread Kangjie Lu
If affs_bread fails, do not use ext_bh to avoid NULL pointer dereference Signed-off-by: Kangjie Lu --- fs/affs/file.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index a85817f54483..45b96faa40f1 100644 --- a/fs/affs/file.c +++ b