Re: [PATCH] fs: proc: check status of register_filesystem

2019-01-02 Thread David Howells
Kangjie Lu wrote: > + pr_err("failed to register the filesystem.\n"); Is it worth saying which filesystem? David

Re: [PATCH] fs: proc: check status of register_filesystem

2019-01-02 Thread David Howells
Alexey Dobriyan wrote: > > - register_filesystem(&proc_fs_type); > > + if (register_filesystem(&proc_fs_type)) > > + pr_err("failed to register the filesystem.\n"); > > No, register_filesystem() should do it. +1 David

Re: [PATCH] fs: proc: check status of register_filesystem

2018-12-25 Thread Al Viro
On Wed, Dec 26, 2018 at 09:18:56AM +0300, Alexey Dobriyan wrote: > On Tue, Dec 25, 2018 at 09:06:40PM -0600, Kangjie Lu wrote: > > register_filesystem() could fail. The fix issues an error message if it > > fails. > > > - register_filesystem(&proc_fs_type); > > + if (register_filesystem(&proc_

Re: [PATCH] fs: proc: check status of register_filesystem

2018-12-25 Thread Alexey Dobriyan
On Tue, Dec 25, 2018 at 09:06:40PM -0600, Kangjie Lu wrote: > register_filesystem() could fail. The fix issues an error message if it > fails. > - register_filesystem(&proc_fs_type); > + if (register_filesystem(&proc_fs_type)) > + pr_err("failed to register the filesystem.\n");

[PATCH] fs: proc: check status of register_filesystem

2018-12-25 Thread Kangjie Lu
register_filesystem() could fail. The fix issues an error message if it fails. Signed-off-by: Kangjie Lu --- fs/proc/root.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/proc/root.c b/fs/proc/root.c index f4b1a9d2eca6..7dcd947cba23 100644 --- a/fs/proc/root.c +++ b/fs/