Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Yang Shi
On 2/23/18 11:45 AM, Alexey Dobriyan wrote: On Fri, Feb 23, 2018 at 11:42:34AM -0800, Yang Shi wrote: On 2/23/18 11:33 AM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: 2) access_remote_vm() et al will do the same ->mmap_sem, and Yes, it does. But,

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Yang Shi
On 2/23/18 11:45 AM, Alexey Dobriyan wrote: On Fri, Feb 23, 2018 at 11:42:34AM -0800, Yang Shi wrote: On 2/23/18 11:33 AM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: 2) access_remote_vm() et al will do the same ->mmap_sem, and Yes, it does. But,

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Alexey Dobriyan
On Fri, Feb 23, 2018 at 11:42:34AM -0800, Yang Shi wrote: > > > On 2/23/18 11:33 AM, Alexey Dobriyan wrote: > > On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: > > > > 2) access_remote_vm() et al will do the same ->mmap_sem, and > Yes, it does. But, __access_remote_vm() is

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Alexey Dobriyan
On Fri, Feb 23, 2018 at 11:42:34AM -0800, Yang Shi wrote: > > > On 2/23/18 11:33 AM, Alexey Dobriyan wrote: > > On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: > > > > 2) access_remote_vm() et al will do the same ->mmap_sem, and > Yes, it does. But, __access_remote_vm() is

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Yang Shi
On 2/23/18 11:33 AM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: 2) access_remote_vm() et al will do the same ->mmap_sem, and Yes, it does. But, __access_remote_vm() is called by access_process_vm() too, which is used by much more places, i.e. ptrace, so

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Yang Shi
On 2/23/18 11:33 AM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: 2) access_remote_vm() et al will do the same ->mmap_sem, and Yes, it does. But, __access_remote_vm() is called by access_process_vm() too, which is used by much more places, i.e. ptrace, so

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Alexey Dobriyan
On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: > >>> 2) access_remote_vm() et al will do the same ->mmap_sem, and > >> Yes, it does. But, __access_remote_vm() is called by access_process_vm() > >> too, which is used by much more places, i.e. ptrace, so I was not sure > >> if it is

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Alexey Dobriyan
On Wed, Feb 21, 2018 at 03:13:10PM -0800, Yang Shi wrote: > >>> 2) access_remote_vm() et al will do the same ->mmap_sem, and > >> Yes, it does. But, __access_remote_vm() is called by access_process_vm() > >> too, which is used by much more places, i.e. ptrace, so I was not sure > >> if it is

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Yang Shi
On 2/21/18 11:57 AM, Alexey Dobriyan wrote: On Tue, Feb 20, 2018 at 03:38:24PM -0800, Yang Shi wrote: On 2/20/18 2:38 PM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-23 Thread Yang Shi
On 2/21/18 11:57 AM, Alexey Dobriyan wrote: On Tue, Feb 20, 2018 at 03:38:24PM -0800, Yang Shi wrote: On 2/20/18 2:38 PM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-21 Thread Yang Shi
On 2/21/18 11:57 AM, Alexey Dobriyan wrote: On Tue, Feb 20, 2018 at 03:38:24PM -0800, Yang Shi wrote: On 2/20/18 2:38 PM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-21 Thread Yang Shi
On 2/21/18 11:57 AM, Alexey Dobriyan wrote: On Tue, Feb 20, 2018 at 03:38:24PM -0800, Yang Shi wrote: On 2/20/18 2:38 PM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-21 Thread Alexey Dobriyan
On Tue, Feb 20, 2018 at 03:38:24PM -0800, Yang Shi wrote: > > > On 2/20/18 2:38 PM, Alexey Dobriyan wrote: > > On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: > >> When running vm-scalability with large memory (> 300GB), the below hung > >> task issue happens occasionally. > >> > >>

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-21 Thread Alexey Dobriyan
On Tue, Feb 20, 2018 at 03:38:24PM -0800, Yang Shi wrote: > > > On 2/20/18 2:38 PM, Alexey Dobriyan wrote: > > On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: > >> When running vm-scalability with large memory (> 300GB), the below hung > >> task issue happens occasionally. > >> > >>

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Yang Shi
On 2/20/18 11:49 AM, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 >

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Yang Shi
On 2/20/18 11:49 AM, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 >

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Yang Shi
On 2/20/18 2:38 PM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Yang Shi
On 2/20/18 2:38 PM, Alexey Dobriyan wrote: On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Alexey Dobriyan
On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: > When running vm-scalability with large memory (> 300GB), the below hung > task issue happens occasionally. > > INFO: task ps:14018 blocked for more than 120 seconds. >Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 >

Re: [PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Alexey Dobriyan
On Wed, Feb 21, 2018 at 03:49:29AM +0800, Yang Shi wrote: > When running vm-scalability with large memory (> 300GB), the below hung > task issue happens occasionally. > > INFO: task ps:14018 blocked for more than 120 seconds. >Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 >

[PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Yang Shi
When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this

[PATCH] fs: proc: use down_read_killable in proc_pid_cmdline_read()

2018-02-20 Thread Yang Shi
When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this