Re: [PATCH] fs: reiserfs: Remove unnecessary check of bh in remove_from_transaction()

2019-07-31 Thread Jan Kara
On Sat 27-07-19 16:40:19, Jia-Ju Bai wrote: > On lines 3430-3434, bh has been assured to be non-null: > cn = get_journal_hash_dev(sb, journal->j_hash_table, blocknr); > if (!cn || !cn->bh) { > return ret; > } > bh = cn->bh; > > Thus, the check of bh on line 3447 is

[PATCH] fs: reiserfs: Remove unnecessary check of bh in remove_from_transaction()

2019-07-27 Thread Jia-Ju Bai
On lines 3430-3434, bh has been assured to be non-null: cn = get_journal_hash_dev(sb, journal->j_hash_table, blocknr); if (!cn || !cn->bh) { return ret; } bh = cn->bh; Thus, the check of bh on line 3447 is unnecessary and can be removed. Thank Andrew Morton for good