Re: [PATCH] fs: split receive_fd_replace from __receive_fd

2021-04-16 Thread Christian Brauner
On Fri, Apr 16, 2021 at 04:15:43AM +, Al Viro wrote: > On Fri, Apr 02, 2021 at 12:01:05PM -0700, Kees Cook wrote: > > On Thu, Mar 25, 2021 at 09:22:09AM +0100, Christoph Hellwig wrote: > > > receive_fd_replace shares almost no code with the general case, so split > > > it out. Also remove the

Re: [PATCH] fs: split receive_fd_replace from __receive_fd

2021-04-15 Thread Al Viro
On Fri, Apr 02, 2021 at 12:01:05PM -0700, Kees Cook wrote: > On Thu, Mar 25, 2021 at 09:22:09AM +0100, Christoph Hellwig wrote: > > receive_fd_replace shares almost no code with the general case, so split > > it out. Also remove the "Bump the sock usage counts" comment from > > both copies, as tha

Re: [PATCH] fs: split receive_fd_replace from __receive_fd

2021-04-15 Thread Al Viro
On Thu, Mar 25, 2021 at 09:22:09AM +0100, Christoph Hellwig wrote: > receive_fd_replace shares almost no code with the general case, so split > it out. Also remove the "Bump the sock usage counts" comment from > both copies, as that is now what __receive_sock actually does. Nice, except that you'

Re: [PATCH] fs: split receive_fd_replace from __receive_fd

2021-04-02 Thread Kees Cook
On Thu, Mar 25, 2021 at 09:22:09AM +0100, Christoph Hellwig wrote: > receive_fd_replace shares almost no code with the general case, so split > it out. Also remove the "Bump the sock usage counts" comment from > both copies, as that is now what __receive_sock actually does. > > Signed-off-by: Chr

[PATCH] fs: split receive_fd_replace from __receive_fd

2021-03-25 Thread Christoph Hellwig
receive_fd_replace shares almost no code with the general case, so split it out. Also remove the "Bump the sock usage counts" comment from both copies, as that is now what __receive_sock actually does. Signed-off-by: Christoph Hellwig --- fs/file.c| 39 +++---