Re: [PATCH] fscache: extended "dying" check before emitting EV_INVALIDATE

2013-04-23 Thread David Howells
Max Kellermann wrote: > Before emitting an FSCACHE_OBJECT_EV_INVALIDATE event, the function > __fscache_invalidate() checks whether the fscache_object is currently > "dying". This checks only the current state, not the queued events > that will very soon lead to the object's death. This should

Re: [PATCH] fscache: extended "dying" check before emitting EV_INVALIDATE

2013-04-23 Thread David Howells
Max Kellermann wrote: > + (object->events & > (FSCACHE_OBJECT_EV_RETIRE|FSCACHE_OBJECT_EV_RELEASE)) == 0) You can't do it like this. EV_RETIRE and EV_RELEASE are bit numbers, so need to be shifted into place. David -- To unsubscribe from this list: send the line

Re: [PATCH] fscache: extended dying check before emitting EV_INVALIDATE

2013-04-23 Thread David Howells
Max Kellermann m...@cm4all.com wrote: + (object-events (FSCACHE_OBJECT_EV_RETIRE|FSCACHE_OBJECT_EV_RELEASE)) == 0) You can't do it like this. EV_RETIRE and EV_RELEASE are bit numbers, so need to be shifted into place. David -- To unsubscribe from this list: send the

Re: [PATCH] fscache: extended dying check before emitting EV_INVALIDATE

2013-04-23 Thread David Howells
Max Kellermann m...@cm4all.com wrote: Before emitting an FSCACHE_OBJECT_EV_INVALIDATE event, the function __fscache_invalidate() checks whether the fscache_object is currently dying. This checks only the current state, not the queued events that will very soon lead to the object's death.

[PATCH] fscache: extended "dying" check before emitting EV_INVALIDATE

2013-04-03 Thread Max Kellermann
Before emitting an FSCACHE_OBJECT_EV_INVALIDATE event, the function __fscache_invalidate() checks whether the fscache_object is currently "dying". This checks only the current state, not the queued events that will very soon lead to the object's death. The problem is that

[PATCH] fscache: extended dying check before emitting EV_INVALIDATE

2013-04-03 Thread Max Kellermann
Before emitting an FSCACHE_OBJECT_EV_INVALIDATE event, the function __fscache_invalidate() checks whether the fscache_object is currently dying. This checks only the current state, not the queued events that will very soon lead to the object's death. The problem is that