Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-28 Thread Rafael J. Wysocki
On Tuesday, March 28, 2017 04:42:18 PM Josh Poimboeuf wrote: > On Tue, Mar 28, 2017 at 11:12:42PM +0200, Rafael J. Wysocki wrote: > > On Tuesday, March 28, 2017 10:55:46 AM Josh Poimboeuf wrote: > > > On Tue, Mar 28, 2017 at 11:39:41AM -0400, Steven Rostedt wrote: > > > > On Tue, 28 Mar 2017 11:51:

Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-28 Thread Josh Poimboeuf
On Tue, Mar 28, 2017 at 11:12:42PM +0200, Rafael J. Wysocki wrote: > On Tuesday, March 28, 2017 10:55:46 AM Josh Poimboeuf wrote: > > On Tue, Mar 28, 2017 at 11:39:41AM -0400, Steven Rostedt wrote: > > > On Tue, 28 Mar 2017 11:51:45 +0200 > > > Paul Menzel wrote: > > > > > > > With both patches a

Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-28 Thread Rafael J. Wysocki
On Tuesday, March 28, 2017 10:55:46 AM Josh Poimboeuf wrote: > On Tue, Mar 28, 2017 at 11:39:41AM -0400, Steven Rostedt wrote: > > On Tue, 28 Mar 2017 11:51:45 +0200 > > Paul Menzel wrote: > > > > > With both patches applied `./analyze_suspend.py -config > > > suspend-callgraph.cfg -filter i915`

Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-28 Thread Josh Poimboeuf
On Tue, Mar 28, 2017 at 11:39:41AM -0400, Steven Rostedt wrote: > On Tue, 28 Mar 2017 11:51:45 +0200 > Paul Menzel wrote: > > > With both patches applied `./analyze_suspend.py -config > > suspend-callgraph.cfg -filter i915` succeeds on a Lenovo X60t, so > > suspend and resume work perfectly, wh

Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-28 Thread Steven Rostedt
On Tue, 28 Mar 2017 11:51:45 +0200 Paul Menzel wrote: > With both patches applied `./analyze_suspend.py -config > suspend-callgraph.cfg -filter i915` succeeds on a Lenovo X60t, so > suspend and resume work perfectly, when tracing is enabled. > > Tested-by: Paul Menzel > > It’d be awesome, if

Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-28 Thread Paul Menzel
Dear Josh, On 03/27/17 17:01, Paul Menzel wrote: On 03/27/17 16:54, Josh Poimboeuf wrote: On x86-32, with CONFIG_FIRMWARE and multiple CPUs, if you enable function graph tracing and then suspend to RAM, it will triple fault and reboot when it resumes. The first fault happens when booting a s

Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-27 Thread Steven Rostedt
On Mon, 27 Mar 2017 17:01:53 +0200 Paul Menzel wrote: > > + /* > > +* When resuming from suspend-to-ram, this function can be indirectly > > +* called from early CPU startup code while the CPU is in real mode, > > +* which would fail miserably. Make sure the stack pointer is a > >

Re: [PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-27 Thread Paul Menzel
Dear Josh, On 03/27/17 16:54, Josh Poimboeuf wrote: On x86-32, with CONFIG_FIRMWARE and multiple CPUs, if you enable function graph tracing and then suspend to RAM, it will triple fault and reboot when it resumes. The first fault happens when booting a secondary CPU: startup_32_smp() load_u

[PATCH] ftrace/x86: fix x86-32 triple fault with graph tracing and suspend-to-ram

2017-03-27 Thread Josh Poimboeuf
On x86-32, with CONFIG_FIRMWARE and multiple CPUs, if you enable function graph tracing and then suspend to RAM, it will triple fault and reboot when it resumes. The first fault happens when booting a secondary CPU: startup_32_smp() load_ucode_ap() prepare_ftrace_return() ftrace_graph