Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-16 Thread Steven Rostedt
On Tue, 16 Feb 2021 16:54:58 +0100 Greg Kroah-Hartman wrote: > On Tue, Feb 16, 2021 at 09:45:39AM -0600, Josh Poimboeuf wrote: > > On Tue, Feb 16, 2021 at 09:51:21AM -0500, Steven Rostedt wrote: > > > On Tue, 16 Feb 2021 12:04:06 +0100 > > > Greg Kroah-Hartman wrote: > > > > > > > Thanks fo

Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 09:45:39AM -0600, Josh Poimboeuf wrote: > On Tue, Feb 16, 2021 at 09:51:21AM -0500, Steven Rostedt wrote: > > On Tue, 16 Feb 2021 12:04:06 +0100 > > Greg Kroah-Hartman wrote: > > > > > Thanks for this. > > > > > > Should I also queue these up for 4.9 and 4.14 which do not

Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-16 Thread Josh Poimboeuf
On Tue, Feb 16, 2021 at 09:51:21AM -0500, Steven Rostedt wrote: > On Tue, 16 Feb 2021 12:04:06 +0100 > Greg Kroah-Hartman wrote: > > > Thanks for this. > > > > Should I also queue these up for 4.9 and 4.14 which do not have these > > commits in them either (but somehow do not show the problem, y

Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-16 Thread Steven Rostedt
On Tue, 16 Feb 2021 12:04:06 +0100 Greg Kroah-Hartman wrote: > Thanks for this. > > Should I also queue these up for 4.9 and 4.14 which do not have these > commits in them either (but somehow do not show the problem, yet)? This bothers me. I want to know exactly why this is a problem. That sai

Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-16 Thread Greg Kroah-Hartman
On Mon, Feb 15, 2021 at 09:00:57PM -0500, Steven Rostedt wrote: > On Mon, 15 Feb 2021 20:06:39 -0500 > Steven Rostedt wrote: > > > Strange, that when I applied this to the latest kernel on a my build > > system (binutils 2.35), it still created all the necessary mcount > > locations?? > > I know

Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-15 Thread Steven Rostedt
On Mon, 15 Feb 2021 20:06:39 -0500 Steven Rostedt wrote: > Strange, that when I applied this to the latest kernel on a my build > system (binutils 2.35), it still created all the necessary mcount > locations?? I know why it worked. If you are using the latest gcc on the latest mainline, it will

Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-15 Thread Steven Rostedt
On Mon, 15 Feb 2021 18:05:04 -0600 Josh Poimboeuf wrote: > On Mon, Feb 15, 2021 at 04:44:46PM -0500, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > Starting with binutils 2.36, sections were being removed if they had weak > > functions that were optimized out. Unfortunately,

Re: [PATCH] ftrace: Do not reference symbols in sections without size

2021-02-15 Thread Josh Poimboeuf
On Mon, Feb 15, 2021 at 04:44:46PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Starting with binutils 2.36, sections were being removed if they had weak > functions that were optimized out. Unfortunately, these weak functions would > leave references to mcount/fentry calls,

[PATCH] ftrace: Do not reference symbols in sections without size

2021-02-15 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Starting with binutils 2.36, sections were being removed if they had weak functions that were optimized out. Unfortunately, these weak functions would leave references to mcount/fentry calls, that would make recordmcount fail to find the symbol that matched the cal