Re: [PATCH] ftrace: Fix missing synchronize_rcu() removing trampoline from kallsyms

2020-09-18 Thread Steven Rostedt
On Fri, 11 Sep 2020 15:26:24 +0200 pet...@infradead.org wrote: > > > Doesn't that mean removing the symbol while the trampoline is potentially > > still in use? > > Hurm.. potentially yes. OK, lets do this first. OK, I queued this up to be tested and sent out for urgent. -- Steve

Re: [PATCH] ftrace: Fix missing synchronize_rcu() removing trampoline from kallsyms

2020-09-11 Thread Adrian Hunter
On 11/09/20 2:41 pm, pet...@infradead.org wrote: > On Tue, Sep 01, 2020 at 12:16:17PM +0300, Adrian Hunter wrote: >> Add synchronize_rcu() after list_del_rcu() in >> ftrace_remove_trampoline_from_kallsyms() to protect readers of >> ftrace_ops_trampoline_list (in ftrace_get_trampoline_kallsym) >>

Re: [PATCH] ftrace: Fix missing synchronize_rcu() removing trampoline from kallsyms

2020-09-11 Thread peterz
On Fri, Sep 11, 2020 at 03:55:22PM +0300, Adrian Hunter wrote: > On 11/09/20 2:41 pm, pet...@infradead.org wrote: > > On Tue, Sep 01, 2020 at 12:16:17PM +0300, Adrian Hunter wrote: > >> Add synchronize_rcu() after list_del_rcu() in > >> ftrace_remove_trampoline_from_kallsyms() to protect readers

Re: [PATCH] ftrace: Fix missing synchronize_rcu() removing trampoline from kallsyms

2020-09-11 Thread peterz
On Tue, Sep 01, 2020 at 12:16:17PM +0300, Adrian Hunter wrote: > Add synchronize_rcu() after list_del_rcu() in > ftrace_remove_trampoline_from_kallsyms() to protect readers of > ftrace_ops_trampoline_list (in ftrace_get_trampoline_kallsym) > which is used when kallsyms is read. > > Fixes:

[PATCH] ftrace: Fix missing synchronize_rcu() removing trampoline from kallsyms

2020-09-01 Thread Adrian Hunter
Add synchronize_rcu() after list_del_rcu() in ftrace_remove_trampoline_from_kallsyms() to protect readers of ftrace_ops_trampoline_list (in ftrace_get_trampoline_kallsym) which is used when kallsyms is read. Fixes: fc0ea795f53c8d ("ftrace: Add symbols for ftrace trampolines") Signed-off-by: