Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-23 Thread Thomas Gleixner
Bhuvanesh, On Wed, 23 Dec 2015, Bhuvanesh wrote: > Apologies for not putting the backtrace earlier. No problem. Let's look at it. > During our regression test of the kernel version 3.14, generated a > warning in futex code and resulted in crash with the backtrace given > below: > > WARNING:

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-23 Thread Bhuvanesh
Hi, > - Why was this patch created in the first place? > >The changelog is completely useless. It does not tell what the >observed issue was or whether this was merily the result of reading >the code and assuming that this is a double free. But it was >certainly not due to a thor

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-21 Thread Davidlohr Bueso
On Sat, 19 Dec 2015, Darren Hart wrote: On Sat, Dec 19, 2015 at 07:24:38PM +0100, Thomas Gleixner wrote: - Why are the reviews so sloppy and useless? The one I'm answering to is just hillarious and the other one picks a random commit, claims that it inadvertantly introduced the issue

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-19 Thread Darren Hart
On Sat, Dec 19, 2015 at 07:24:38PM +0100, Thomas Gleixner wrote: > - Why are the reviews so sloppy and useless? > >The one I'm answering to is just hillarious and the other one picks >a random commit, claims that it inadvertantly introduced the issue >and is done with it. Really helpf

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-19 Thread Thomas Gleixner
On Fri, 18 Dec 2015, Davidlohr Bueso wrote: > On Fri, 18 Dec 2015, bhuvanesh_surach...@mentor.com wrote: > > > From: Bhuvanesh Surachari > > > > In case of error from rt_mutex_start_proxy_lock pi_state is freed > > twice in futex_requeue function. Hence removing free_pi_state in > > else branch

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-18 Thread Darren Hart
On Fri, Dec 18, 2015 at 02:13:43PM +0530, bhuvanesh_surach...@mentor.com wrote: > From: Bhuvanesh Surachari > > In case of error from rt_mutex_start_proxy_lock pi_state is freed > twice in futex_requeue function. Hence removing free_pi_state in > else branch and branching to the location where pi

Re: [PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-18 Thread Davidlohr Bueso
On Fri, 18 Dec 2015, bhuvanesh_surach...@mentor.com wrote: From: Bhuvanesh Surachari In case of error from rt_mutex_start_proxy_lock pi_state is freed twice in futex_requeue function. Hence removing free_pi_state in else branch and branching to the location where pi_state is freed. This read

[PATCH] futex: Prevent pi_state from double freeing in case of error

2015-12-18 Thread Bhuvanesh_Surachari
From: Bhuvanesh Surachari In case of error from rt_mutex_start_proxy_lock pi_state is freed twice in futex_requeue function. Hence removing free_pi_state in else branch and branching to the location where pi_state is freed. Signed-off-by: Bhuvanesh Surachari Signed-off-by: Andy Lowe --- kerne