Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2021-01-19 Thread Masahiro Yamada
On Wed, Jan 20, 2021 at 2:48 AM Thierry Reding wrote: > > On Fri, Dec 18, 2020 at 08:33:37PM +, Jon Hunter wrote: > > > > On 18/12/2020 17:54, Linus Torvalds wrote: > > > On Fri, Dec 18, 2020 at 7:33 AM Jon Hunter wrote: > > >> > > >> However, if you are saying that this is a problem/bug

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2021-01-19 Thread Thierry Reding
On Fri, Dec 18, 2020 at 08:33:37PM +, Jon Hunter wrote: > > On 18/12/2020 17:54, Linus Torvalds wrote: > > On Fri, Dec 18, 2020 at 7:33 AM Jon Hunter wrote: > >> > >> However, if you are saying that this is a problem/bug with our builders, > >> then of course we will have to get this fixed.

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Jon Hunter
On 18/12/2020 17:54, Linus Torvalds wrote: > On Fri, Dec 18, 2020 at 7:33 AM Jon Hunter wrote: >> >> However, if you are saying that this is a problem/bug with our builders, >> then of course we will have to get this fixed. > > This seems to be a package dependency problem with the gcc plugins

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Linus Torvalds
On Fri, Dec 18, 2020 at 7:33 AM Jon Hunter wrote: > > However, if you are saying that this is a problem/bug with our builders, > then of course we will have to get this fixed. This seems to be a package dependency problem with the gcc plugins - they clearly want libgmp, but apparently the

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Thierry Reding
On Sat, Dec 19, 2020 at 12:42:51AM +0900, Masahiro Yamada wrote: > On Sat, Dec 19, 2020 at 12:33 AM Jon Hunter wrote: > > > > > > On 18/12/2020 15:12, Jon Hunter wrote: > > > > > > On 18/12/2020 15:09, Marek Szyprowski wrote: > > >> > > >> On 18.12.2020 16:03, Jon Hunter wrote: > > >>> On

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Jon Hunter
On 18/12/2020 15:42, Masahiro Yamada wrote: ... >> However, if you are saying that this is a problem/bug with our builders, >> then of course we will have to get this fixed. >> > > > Yes, please do so. > > > Kconfig evaluates $(CC) capabilities, and > hides CONFIG options it cannot

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Masahiro Yamada
On Sat, Dec 19, 2020 at 12:33 AM Jon Hunter wrote: > > > On 18/12/2020 15:12, Jon Hunter wrote: > > > > On 18/12/2020 15:09, Marek Szyprowski wrote: > >> > >> On 18.12.2020 16:03, Jon Hunter wrote: > >>> On 18/12/2020 10:05, Marek Szyprowski wrote: > On 18.12.2020 10:43, Masahiro Yamada

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Jon Hunter
On 18/12/2020 15:12, Jon Hunter wrote: > > On 18/12/2020 15:09, Marek Szyprowski wrote: >> >> On 18.12.2020 16:03, Jon Hunter wrote: >>> On 18/12/2020 10:05, Marek Szyprowski wrote: On 18.12.2020 10:43, Masahiro Yamada wrote: > On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski >

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Jon Hunter
On 18/12/2020 15:09, Marek Szyprowski wrote: > > On 18.12.2020 16:03, Jon Hunter wrote: >> On 18/12/2020 10:05, Marek Szyprowski wrote: >>> On 18.12.2020 10:43, Masahiro Yamada wrote: On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski wrote: > On 03.12.2020 13:57, Masahiro Yamada

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Marek Szyprowski
On 18.12.2020 16:03, Jon Hunter wrote: > On 18/12/2020 10:05, Marek Szyprowski wrote: >> On 18.12.2020 10:43, Masahiro Yamada wrote: >>> On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski >>> wrote: On 03.12.2020 13:57, Masahiro Yamada wrote: > Linus pointed out a third of the time in

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Jon Hunter
On 18/12/2020 10:05, Marek Szyprowski wrote: > On 18.12.2020 10:43, Masahiro Yamada wrote: >> On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski >> wrote: >>> On 03.12.2020 13:57, Masahiro Yamada wrote: Linus pointed out a third of the time in the Kconfig parse stage comes from the

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Marek Szyprowski
On 18.12.2020 10:43, Masahiro Yamada wrote: > On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski > wrote: >> On 03.12.2020 13:57, Masahiro Yamada wrote: >>> Linus pointed out a third of the time in the Kconfig parse stage comes >>> from the single invocation of cc1plus in scripts/gcc-plugin.sh [1],

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Masahiro Yamada
On Fri, Dec 18, 2020 at 4:58 PM Marek Szyprowski wrote: > > Hi, > > On 03.12.2020 13:57, Masahiro Yamada wrote: > > Linus pointed out a third of the time in the Kconfig parse stage comes > > from the single invocation of cc1plus in scripts/gcc-plugin.sh [1], > > and directly testing

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-18 Thread Marek Szyprowski
Hi, On 03.12.2020 13:57, Masahiro Yamada wrote: > Linus pointed out a third of the time in the Kconfig parse stage comes > from the single invocation of cc1plus in scripts/gcc-plugin.sh [1], > and directly testing plugin-version.h for existence cuts down the > overhead a lot. [2] > > This commit

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-04 Thread Kees Cook
On Thu, 3 Dec 2020 21:57:00 +0900, Masahiro Yamada wrote: > Linus pointed out a third of the time in the Kconfig parse stage comes > from the single invocation of cc1plus in scripts/gcc-plugin.sh [1], > and directly testing plugin-version.h for existence cuts down the > overhead a lot. [2] > >

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-04 Thread Kees Cook
On Thu, Dec 03, 2020 at 09:57:00PM +0900, Masahiro Yamada wrote: > Linus pointed out a third of the time in the Kconfig parse stage comes > from the single invocation of cc1plus in scripts/gcc-plugin.sh [1], > and directly testing plugin-version.h for existence cuts down the > overhead a lot. [2]

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-03 Thread Linus Torvalds
On Thu, Dec 3, 2020 at 5:03 AM Masahiro Yamada wrote: > > Checking the existence of plugin-version.h is still needed to ensure > the plugin-dev package is installed. The test code is now small enough > to be embedded in scripts/gcc-plugins/Kconfig. Ack. I think the "plugin" directory name should

[PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2020-12-03 Thread Masahiro Yamada
Linus pointed out a third of the time in the Kconfig parse stage comes from the single invocation of cc1plus in scripts/gcc-plugin.sh [1], and directly testing plugin-version.h for existence cuts down the overhead a lot. [2] This commit takes one step further to kill the build test entirely. The