Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 14:53:33 -0700 Kees Cook wrote: > > Well, I do think that a description of the user impact of the bug > > should be included in the changelog so that poor old Greg can work out > > why we sent it at him. > > > > If you can suggest some suitable text I can copy-n-slurp that

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Kees Cook
On Wed, Oct 24, 2012 at 2:44 PM, Andrew Morton wrote: > On Wed, 24 Oct 2012 14:33:02 -0700 > Kees Cook wrote: > >> On Wed, Oct 24, 2012 at 2:02 PM, Andrew Morton >> wrote: >> > On Wed, 24 Oct 2012 13:57:56 -0700 >> > Kees Cook wrote: >> > >> >> Fix possible overflow of the buffer used for

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 14:33:02 -0700 Kees Cook wrote: > On Wed, Oct 24, 2012 at 2:02 PM, Andrew Morton > wrote: > > On Wed, 24 Oct 2012 13:57:56 -0700 > > Kees Cook wrote: > > > >> Fix possible overflow of the buffer used for expanding environment > >> variables when building file list. > >> >

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Kees Cook
On Wed, Oct 24, 2012 at 2:02 PM, Andrew Morton wrote: > On Wed, 24 Oct 2012 13:57:56 -0700 > Kees Cook wrote: > >> Fix possible overflow of the buffer used for expanding environment >> variables when building file list. >> >> $ cat usr/crash.list >> file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG}

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 13:57:56 -0700 Kees Cook wrote: > Fix possible overflow of the buffer used for expanding environment > variables when building file list. > > $ cat usr/crash.list > file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG} 0755 0 0 > $ BIG=$(perl -e 'print "A" x 4096;')

[RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Kees Cook
Fix possible overflow of the buffer used for expanding environment variables when building file list. $ cat usr/crash.list file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG} 0755 0 0 $ BIG=$(perl -e 'print "A" x 4096;') ./usr/gen_init_cpio usr/crash.list *** buffer overflow detected ***:

[RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Kees Cook
Fix possible overflow of the buffer used for expanding environment variables when building file list. $ cat usr/crash.list file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG} 0755 0 0 $ BIG=$(perl -e 'print A x 4096;') ./usr/gen_init_cpio usr/crash.list *** buffer overflow detected ***:

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 13:57:56 -0700 Kees Cook keesc...@chromium.org wrote: Fix possible overflow of the buffer used for expanding environment variables when building file list. $ cat usr/crash.list file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG} 0755 0 0 $ BIG=$(perl -e 'print A x 4096;')

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Kees Cook
On Wed, Oct 24, 2012 at 2:02 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 24 Oct 2012 13:57:56 -0700 Kees Cook keesc...@chromium.org wrote: Fix possible overflow of the buffer used for expanding environment variables when building file list. $ cat usr/crash.list file foo

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 14:33:02 -0700 Kees Cook keesc...@chromium.org wrote: On Wed, Oct 24, 2012 at 2:02 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 24 Oct 2012 13:57:56 -0700 Kees Cook keesc...@chromium.org wrote: Fix possible overflow of the buffer used for expanding

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Kees Cook
On Wed, Oct 24, 2012 at 2:44 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 24 Oct 2012 14:33:02 -0700 Kees Cook keesc...@chromium.org wrote: On Wed, Oct 24, 2012 at 2:02 PM, Andrew Morton a...@linux-foundation.org wrote: On Wed, 24 Oct 2012 13:57:56 -0700 Kees Cook

Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-24 Thread Andrew Morton
On Wed, 24 Oct 2012 14:53:33 -0700 Kees Cook keesc...@chromium.org wrote: Well, I do think that a description of the user impact of the bug should be included in the changelog so that poor old Greg can work out why we sent it at him. If you can suggest some suitable text I can

[PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-11 Thread Kees Cook
Fix possible overflow of the buffer used for expanding environment variables when building file list. $ cat usr/crash.list file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG} 0755 0 0 $ BIG=$(perl -e 'print "A" x 4096;') ./usr/gen_init_cpio usr/crash.list *** buffer overflow detected ***:

[PATCH] gen_init_cpio: avoid stack overflow when expanding

2012-10-11 Thread Kees Cook
Fix possible overflow of the buffer used for expanding environment variables when building file list. $ cat usr/crash.list file foo ${BIG}${BIG}${BIG}${BIG}${BIG}${BIG} 0755 0 0 $ BIG=$(perl -e 'print A x 4096;') ./usr/gen_init_cpio usr/crash.list *** buffer overflow detected ***: