Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths

2007-07-03 Thread Alan Cox
On Tue, 03 Jul 2007 23:36:22 +0200 Morten Helgesen <[EMAIL PROTECTED]> wrote: > /* > > Problems to take into account are: > > -1- Interrupts that empty part of the buffer. > -> -2- page faults on the access to userspace. > +> -2- Page faults on access to userspace. #2 no l

Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths

2007-07-03 Thread Morten Helgesen
Alan Cox wrote: On Tue, 03 Jul 2007 16:39:05 +0200 Morten Helgesen <[EMAIL PROTECTED]> wrote: Alan Cox wrote: [...snip...] @@ -75,11 +64,11 @@ if (! (port->flags & ASYNC_INITIALIZED)) return; /* Take a lock on the serial tranmit buffer! */ - LOCKIT; + mutex_lo

Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths

2007-07-03 Thread Morten Helgesen
Alan Cox wrote: On Tue, 03 Jul 2007 16:39:05 +0200 Morten Helgesen <[EMAIL PROTECTED]> wrote: Alan Cox wrote: [...snip...] @@ -75,11 +64,11 @@ if (! (port->flags & ASYNC_INITIALIZED)) return; /* Take a lock on the serial tranmit buffer! */ - LOCKIT; + mutex_lo

Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths

2007-07-03 Thread Alan Cox
On Tue, 03 Jul 2007 16:39:05 +0200 Morten Helgesen <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > [...snip...] > > @@ -75,11 +64,11 @@ > > if (! (port->flags & ASYNC_INITIALIZED)) return; > > > > /* Take a lock on the serial tranmit buffer! */ > > - LOCKIT; > > + mutex_lock(& port

Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths

2007-07-03 Thread Morten Helgesen
Alan Cox wrote: [...snip...] @@ -75,11 +64,11 @@ if (! (port->flags & ASYNC_INITIALIZED)) return; /* Take a lock on the serial tranmit buffer! */ - LOCKIT; + mutex_lock(& port->port_write_mutex); ^ Contains additional whitespace. if (port->xmit_cnt >= SERI

[PATCH] genericserial: Remove bogus optimisation check and dead code paths

2007-07-03 Thread Alan Cox
We've been using the 'new locking' for a long time now so it seems pointless keeping the old one around. Remove it and undo the macros it uses back into real code for readability. Remove the bogus 'no termios change' checks. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --exclude