Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-22 Thread Thomas Gleixner
Chen, On Fri, 18 Jan 2019, Huacai Chen wrote: > > > I did not say that you removed all NULL returns. I said that this function > > > can return NULL for other reasons and then the same situation will happen. > > > > > > If the masks pointer returned is NULL then the calling code or any > > > subse

Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-17 Thread Huacai Chen
uot;linux-kernel"; "Fuxin > Zhang"; "wuzhangjin"; > "stable"; "Christoph Hellwig"; "Michael > Hernandez"; > Subject: Re: [PATCH] genirq/affinity: Assign default affinity to pre/post > vectors > > Chen, >

Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-16 Thread 陈华才
ot;Christoph Hellwig"; "Michael Hernandez"; Subject: Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors Chen, On Wed, 16 Jan 2019, 陈华才 wrote: > please do not top-post and use line breaks around 78 char. > I'm not removing all return NULL of irq_cre

Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-16 Thread Thomas Gleixner
-- Original -- > From: "Thomas Gleixner"; > Date: Wed, Jan 16, 2019 03:10 AM > To: "Huacai Chen"; > Cc: "linux-kernel"; "Fuxin > Zhang"; "wuzhangjin"; > "stable"; "Christoph Hellwig"; "Michael &g

Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-15 Thread 陈华才
Zhang"; "wuzhangjin"; "stable"; "Christoph Hellwig"; "Michael Hernandez"; Subject: Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors On Mon, 31 Dec 2018, Huacai Chen wrote: > Generally, irq_create_affinity_masks() assign

Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-15 Thread Thomas Gleixner
On Mon, 31 Dec 2018, Huacai Chen wrote: > Generally, irq_create_affinity_masks() assign default affinity to pre/ > post vectors correctly. However, it ignore the case that there are only > pre/post vectors (when nvecs == affd->pre_vectors + affd->post_vectors) > and return NULL. This case usually

[PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2018-12-30 Thread Huacai Chen
Generally, irq_create_affinity_masks() assign default affinity to pre/ post vectors correctly. However, it ignore the case that there are only pre/post vectors (when nvecs == affd->pre_vectors + affd->post_vectors) and return NULL. This case usually happens when nvecs = 1 (e.g. in nvme driver when