Re: [PATCH] genirq/affinity: report extra vectors on uneven nodes

2019-08-08 Thread Ming Lei
On Thu, Aug 08, 2019 at 10:32:24AM -0600, Keith Busch wrote: > On Thu, Aug 08, 2019 at 09:04:28AM +0200, Thomas Gleixner wrote: > > On Wed, 7 Aug 2019, Jon Derrick wrote: > > > The current irq spreading algorithm spreads vectors amongst cpus evenly > > > per node. If a node has more cpus than anoth

Re: [PATCH] genirq/affinity: report extra vectors on uneven nodes

2019-08-08 Thread Keith Busch
On Thu, Aug 08, 2019 at 10:46:06PM +, Derrick, Jonathan wrote: > On Thu, 2019-08-08 at 10:32 -0600, Keith Busch wrote: > > > > I think the real problem is the spread's vecs_per_node doesn't account > > which nodes contribute more CPUs than others. For example: > > > > Node 0 has 32 CPUs > >

Re: [PATCH] genirq/affinity: report extra vectors on uneven nodes

2019-08-08 Thread Derrick, Jonathan
On Thu, 2019-08-08 at 10:32 -0600, Keith Busch wrote: > On Thu, Aug 08, 2019 at 09:04:28AM +0200, Thomas Gleixner wrote: > > On Wed, 7 Aug 2019, Jon Derrick wrote: > > > The current irq spreading algorithm spreads vectors amongst cpus evenly > > > per node. If a node has more cpus than another node

Re: [PATCH] genirq/affinity: report extra vectors on uneven nodes

2019-08-08 Thread Keith Busch
On Thu, Aug 08, 2019 at 09:04:28AM +0200, Thomas Gleixner wrote: > On Wed, 7 Aug 2019, Jon Derrick wrote: > > The current irq spreading algorithm spreads vectors amongst cpus evenly > > per node. If a node has more cpus than another node, the extra vectors > > being spread may not be reported back

Re: [PATCH] genirq/affinity: report extra vectors on uneven nodes

2019-08-08 Thread Thomas Gleixner
On Wed, 7 Aug 2019, Jon Derrick wrote: Cc+: Ming, Christoph. Left context for reference. > The current irq spreading algorithm spreads vectors amongst cpus evenly > per node. If a node has more cpus than another node, the extra vectors > being spread may not be reported back to the caller. > >

[PATCH] genirq/affinity: report extra vectors on uneven nodes

2019-08-07 Thread Jon Derrick
The current irq spreading algorithm spreads vectors amongst cpus evenly per node. If a node has more cpus than another node, the extra vectors being spread may not be reported back to the caller. This is most apparent with the NVMe driver and nr_cpus < vectors, where the underreporting results in