Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-11 Thread Mika Westerberg
On Fri, Oct 11, 2013 at 12:57:37PM +0200, Linus Walleij wrote: > On Tue, Oct 1, 2013 at 4:35 PM, Mika Westerberg > wrote: > > > Checking LP_INT_STAT is not enough in the interrupt handler because its > > contents get updated regardless of whether the pin has interrupt enabled or > > not. This

Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-11 Thread Linus Walleij
On Tue, Oct 1, 2013 at 4:35 PM, Mika Westerberg wrote: > Checking LP_INT_STAT is not enough in the interrupt handler because its > contents get updated regardless of whether the pin has interrupt enabled or > not. This causes the driver to loop forever for GPIOs that are pulled up. > > Fix this

Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-11 Thread Linus Walleij
On Tue, Oct 1, 2013 at 4:35 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Checking LP_INT_STAT is not enough in the interrupt handler because its contents get updated regardless of whether the pin has interrupt enabled or not. This causes the driver to loop forever for GPIOs that

Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-11 Thread Mika Westerberg
On Fri, Oct 11, 2013 at 12:57:37PM +0200, Linus Walleij wrote: On Tue, Oct 1, 2013 at 4:35 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: Checking LP_INT_STAT is not enough in the interrupt handler because its contents get updated regardless of whether the pin has interrupt

Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-02 Thread Mathias Nyman
On 10/01/2013 05:35 PM, Mika Westerberg wrote: Checking LP_INT_STAT is not enough in the interrupt handler because its contents get updated regardless of whether the pin has interrupt enabled or not. This causes the driver to loop forever for GPIOs that are pulled up. Fix this by checking the

Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-02 Thread Mathias Nyman
On 10/01/2013 05:35 PM, Mika Westerberg wrote: Checking LP_INT_STAT is not enough in the interrupt handler because its contents get updated regardless of whether the pin has interrupt enabled or not. This causes the driver to loop forever for GPIOs that are pulled up. Fix this by checking the

[PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-01 Thread Mika Westerberg
Checking LP_INT_STAT is not enough in the interrupt handler because its contents get updated regardless of whether the pin has interrupt enabled or not. This causes the driver to loop forever for GPIOs that are pulled up. Fix this by checking the interrupt enable bit for the pin as well.

[PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-01 Thread Mika Westerberg
Checking LP_INT_STAT is not enough in the interrupt handler because its contents get updated regardless of whether the pin has interrupt enabled or not. This causes the driver to loop forever for GPIOs that are pulled up. Fix this by checking the interrupt enable bit for the pin as well.