Re: [PATCH] gpio: 74x164: add lines-initial-states property

2018-08-19 Thread David Bauer
Hi Linus, On 8/16/18 10:11 AM, Linus Walleij wrote: > This sounds like something that should be generic, and not use > a bitmask, but offsets. It should work even if the number of > GPIOs from the chip is > 32. > > Is the usecase different from hogs? > See

Re: [PATCH] gpio: 74x164: add lines-initial-states property

2018-08-19 Thread David Bauer
Hi Linus, On 8/16/18 10:11 AM, Linus Walleij wrote: > This sounds like something that should be generic, and not use > a bitmask, but offsets. It should work even if the number of > GPIOs from the chip is > 32. > > Is the usecase different from hogs? > See

Re: [PATCH] gpio: 74x164: add lines-initial-states property

2018-08-17 Thread Rob Herring
Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Wed, 15 Aug 2018 22:18:54 +0200, David Bauer wrote: > This adds the ability to define the initial state of each output line on > device probe. > > Signed-off-by:

Re: [PATCH] gpio: 74x164: add lines-initial-states property

2018-08-17 Thread Rob Herring
Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Wed, 15 Aug 2018 22:18:54 +0200, David Bauer wrote: > This adds the ability to define the initial state of each output line on > device probe. > > Signed-off-by:

Re: [PATCH] gpio: 74x164: add lines-initial-states property

2018-08-16 Thread Linus Walleij
Hi David, On Wed, Aug 15, 2018 at 10:19 PM David Bauer wrote: > This adds the ability to define the initial state of each output line on > device probe. > > Signed-off-by: David Bauer (...) > Optional properties: > - enable-gpios: GPIO connected to the OE (Output Enable) pin. > +-

Re: [PATCH] gpio: 74x164: add lines-initial-states property

2018-08-16 Thread Linus Walleij
Hi David, On Wed, Aug 15, 2018 at 10:19 PM David Bauer wrote: > This adds the ability to define the initial state of each output line on > device probe. > > Signed-off-by: David Bauer (...) > Optional properties: > - enable-gpios: GPIO connected to the OE (Output Enable) pin. > +-

[PATCH] gpio: 74x164: add lines-initial-states property

2018-08-15 Thread David Bauer
This adds the ability to define the initial state of each output line on device probe. Signed-off-by: David Bauer --- Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 5 + drivers/gpio/gpio-74x164.c | 3 +++ 2 files changed, 8 insertions(+) diff --git

[PATCH] gpio: 74x164: add lines-initial-states property

2018-08-15 Thread David Bauer
This adds the ability to define the initial state of each output line on device probe. Signed-off-by: David Bauer --- Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 5 + drivers/gpio/gpio-74x164.c | 3 +++ 2 files changed, 8 insertions(+) diff --git