Re: [PATCH] gpio: bd70528: remove unneeded break

2020-10-22 Thread Vaittinen, Matti
Hello, On Wed, 2020-10-21 at 07:39 -0700, Joe Perches wrote: > On Wed, 2020-10-21 at 07:25 +, Vaittinen, Matti wrote: > > Hello Joe & All, > > On Tue, 2020-10-20 at 11:36 -0700, Joe Perches wrote: > > > On Tue, 2020-10-20 at 11:48 +, Vaittinen, Matti wrote: > [] > > > > And for peeps who

Re: [PATCH] gpio: bd70528: remove unneeded break

2020-10-21 Thread Joe Perches
On Wed, 2020-10-21 at 07:25 +, Vaittinen, Matti wrote: > Hello Joe & All, > On Tue, 2020-10-20 at 11:36 -0700, Joe Perches wrote: > > On Tue, 2020-10-20 at 11:48 +, Vaittinen, Matti wrote: [] > > > And for peeps who have not been following - following function > > > triggers the checkpatch

Re: [PATCH] gpio: bd70528: remove unneeded break

2020-10-20 Thread Joe Perches
On Tue, 2020-10-20 at 11:48 +, Vaittinen, Matti wrote: > On Tue, 2020-10-20 at 13:07 +0300, Matti Vaittinen wrote: > > Thanks Tom, > > > > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > > > From: Tom Rix > > > > > > A break is not needed if it is preceded by a return > > > > >

Re: [PATCH] gpio: bd70528: remove unneeded break

2020-10-20 Thread Vaittinen, Matti
On Tue, 2020-10-20 at 14:46 +0300, Andy Shevchenko wrote: > On Tue, Oct 20, 2020 at 2:26 PM Vaittinen, Matti > wrote: > > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > > > - break; > > My personal taste is also to omit these breaks but I am pretty sure > > I > > saw

Re: [PATCH] gpio: bd70528: remove unneeded break

2020-10-20 Thread Vaittinen, Matti
On Tue, 2020-10-20 at 13:07 +0300, Matti Vaittinen wrote: > Thanks Tom, > > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > A break is not needed if it is preceded by a return > > > > Signed-off-by: Tom Rix > > --- > > drivers/gpio/gpio-bd70528.c | 3 --- >

Re: [PATCH] gpio: bd70528: remove unneeded break

2020-10-20 Thread Andy Shevchenko
On Tue, Oct 20, 2020 at 2:26 PM Vaittinen, Matti wrote: > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > > - break; > My personal taste is also to omit these breaks but I am pretty sure I > saw some tooling issuing a warning about falling through the switch- > case back

Re: [PATCH] gpio: bd70528: remove unneeded break

2020-10-20 Thread Vaittinen, Matti
Thanks Tom, On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix > --- > drivers/gpio/gpio-bd70528.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpio/gpio-bd70528.c

[PATCH] gpio: bd70528: remove unneeded break

2020-10-19 Thread trix
From: Tom Rix A break is not needed if it is preceded by a return Signed-off-by: Tom Rix --- drivers/gpio/gpio-bd70528.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpio-bd70528.c b/drivers/gpio/gpio-bd70528.c index 45b3da8da336..931e5765fe92 100644 ---