Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-08-01 Thread Masahiro Yamada
Hi. 2017-08-01 20:04 GMT+09:00 Andy Shevchenko : > On Tue, Aug 1, 2017 at 10:53 AM, Linus Walleij > wrote: >> On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko >> wrote: >>> On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote: On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko wrote:

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-08-01 Thread Thor Thayer
On 07/03/2017 10:53 PM, Masahiro Yamada wrote: Some of include directives in include/linux/gpio/driver.h are unneeded because the header does not need to know the content of struct device, irq_chip, etc. Just declare they are structures. On the other hand, and turned out to be necessary for i

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-08-01 Thread Andy Shevchenko
On Tue, Aug 1, 2017 at 10:53 AM, Linus Walleij wrote: > On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko > wrote: >> On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote: >>> On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko >>> wrote: >>> > If Linus is okay with the following proposal I would

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-08-01 Thread Linus Walleij
On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko wrote: > On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote: >> On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko >> wrote: >> > On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote: >> > > Some of include directives in include/linux/gpio/dr

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-31 Thread Andy Shevchenko
On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote: > On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko > wrote: > > On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote: > > > Some of include directives in include/linux/gpio/driver.h are > > > unneeded because the header does not need to k

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-31 Thread Linus Walleij
On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko wrote: > On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote: >> Some of include directives in include/linux/gpio/driver.h are >> unneeded because the header does not need to know the content of >> struct device, irq_chip, etc. Just declare th

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-05 Thread kbuild test robot
Hi Masahiro, [auto build test ERROR on next-20170705] [cannot apply to gpio/for-next tegra/for-next xlnx/master v4.12 v4.12-rc7 v4.12-rc6 v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/M

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-05 Thread kbuild test robot
Hi Masahiro, [auto build test ERROR on next-20170705] [cannot apply to gpio/for-next tegra/for-next xlnx/master v4.12 v4.12-rc7 v4.12-rc6 v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/M

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-04 Thread Andy Shevchenko
On Tue, Jul 4, 2017 at 6:43 PM, Masahiro Yamada wrote: > 2017-07-04 21:58 GMT+09:00 William Breathitt Gray : > So, I need to think about how to merge this (if the basic idea of this is OK). > > Maybe, > > [1] Send patches to subsystems (gpio, pinctrl, etc.) for v4.14 > [2] Drop unneeded includes

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-04 Thread Masahiro Yamada
2017-07-04 21:58 GMT+09:00 William Breathitt Gray : > On Tue, Jul 04, 2017 at 12:53:34PM +0900, Masahiro Yamada wrote: >>Some of include directives in include/linux/gpio/driver.h are >>unneeded because the header does not need to know the content of >>struct device, irq_chip, etc. Just declare the

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-04 Thread William Breathitt Gray
On Tue, Jul 04, 2017 at 12:53:34PM +0900, Masahiro Yamada wrote: >Some of include directives in include/linux/gpio/driver.h are >unneeded because the header does not need to know the content of >struct device, irq_chip, etc. Just declare they are structures. > >On the other hand, and >turned out

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-04 Thread Masahiro Yamada
2017-07-04 19:06 GMT+09:00 Andy Shevchenko : > On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote: >> Some of include directives in include/linux/gpio/driver.h are >> unneeded because the header does not need to know the content of >> struct device, irq_chip, etc. Just declare they are struc

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-04 Thread Andy Shevchenko
On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote: > Some of include directives in include/linux/gpio/driver.h are > unneeded because the header does not need to know the content of > struct device, irq_chip, etc.  Just declare they are structures. > > On the other hand, and > turned out

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-04 Thread Charles Keepax
On Tue, Jul 04, 2017 at 12:53:34PM +0900, Masahiro Yamada wrote: > Some of include directives in include/linux/gpio/driver.h are > unneeded because the header does not need to know the content of > struct device, irq_chip, etc. Just declare they are structures. > > On the other hand, and > turn

[PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-03 Thread Masahiro Yamada
Some of include directives in include/linux/gpio/driver.h are unneeded because the header does not need to know the content of struct device, irq_chip, etc. Just declare they are structures. On the other hand, and turned out to be necessary for irq_flow_handler_t and spinlock_t, respectively.