Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-15 Thread Jamie Iles
Hi Hoan, On Tue, Feb 14, 2017 at 05:22:09PM -0800, Hoan Tran wrote: > Hi Linus, Jamie and all, > > Do you have any comments on this patch? I think that the CONFIG_ACPI ifdef can be removed to clean it up - acpi_match_device() returns NULL for !CONFIG_ACPI. Other than that, looks good to me. J

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-14 Thread Hoan Tran
Hi Linus, Jamie and all, Do you have any comments on this patch? Thanks Hoan On Mon, Feb 13, 2017 at 1:38 AM, Jamie Iles wrote: > Hi Linus, > > On Mon, Feb 06, 2017 at 11:21:09AM +0100, Linus Walleij wrote: >> On Tue, Jan 31, 2017 at 8:43 PM, Hoan Tran wrote: >> >> > Next generation of X-Gene

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-13 Thread Jamie Iles
Hi Linus, On Mon, Feb 06, 2017 at 11:21:09AM +0100, Linus Walleij wrote: > On Tue, Jan 31, 2017 at 8:43 PM, Hoan Tran wrote: > > > Next generation of X-Gene SoC's GPIO hardware register map is very > > similar to DW GPIO. It only differs by a few register addresses. > > This patch modifies DW GP

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-07 Thread Andy Shevchenko
On Tue, Feb 7, 2017 at 1:49 AM, Hoan Tran wrote: >> I wonder what is at addresses 0x08, 0x14, 0x20, 0x2c, 0x44? > > They are unused registers. > - 0x8, 0x14, 0x20, 0x2c are port data source registers. > - 0x44 is the raw interrupt status register. > >> Anything interesting we should know about?

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-06 Thread Hoan Tran
Resend with plain text. Hi Linus, On Mon, Feb 6, 2017 at 2:21 AM, Linus Walleij wrote: > On Tue, Jan 31, 2017 at 8:43 PM, Hoan Tran wrote: > >> Next generation of X-Gene SoC's GPIO hardware register map is very >> similar to DW GPIO. It only differs by a few register addresses. >> This patch m

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-06 Thread Linus Walleij
On Tue, Jan 31, 2017 at 8:43 PM, Hoan Tran wrote: > Next generation of X-Gene SoC's GPIO hardware register map is very > similar to DW GPIO. It only differs by a few register addresses. > This patch modifies DW GPIO driver to accommodate the difference > in a few register addresses. > > Signed-of

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-02 Thread Hoan Tran
Resend with plain text mode. Hi Andy, On Thu, Feb 2, 2017 at 11:47 AM, Andy Shevchenko wrote: > On Tue, Jan 31, 2017 at 9:43 PM, Hoan Tran wrote: >> Next generation of X-Gene SoC's GPIO hardware register map is very >> similar to DW GPIO. It only differs by a few register addresses. >> This pat

Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-02-02 Thread Andy Shevchenko
On Tue, Jan 31, 2017 at 9:43 PM, Hoan Tran wrote: > Next generation of X-Gene SoC's GPIO hardware register map is very > similar to DW GPIO. It only differs by a few register addresses. > This patch modifies DW GPIO driver to accommodate the difference > in a few register addresses. > +#define GP

[PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC

2017-01-31 Thread Hoan Tran
Next generation of X-Gene SoC's GPIO hardware register map is very similar to DW GPIO. It only differs by a few register addresses. This patch modifies DW GPIO driver to accommodate the difference in a few register addresses. Signed-off-by: Hoan Tran --- drivers/gpio/gpio-dwapb.c | 84 ++