Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-06 Thread Mika Westerberg
On Thu, Mar 07, 2013 at 04:23:56AM +0100, Linus Walleij wrote: > Hi Mika, > > On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg > wrote: > > > -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) > > +static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-06 Thread Linus Walleij
Hi Mika, On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg wrote: > -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) > +static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) > { > - return (ichx_priv.use_gpio & (1 << (nr / 32))) ? 0 : -ENXIO;

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-06 Thread Linus Walleij
Hi Mika, On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) +static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) { - return (ichx_priv.use_gpio (1

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-06 Thread Mika Westerberg
On Thu, Mar 07, 2013 at 04:23:56AM +0100, Linus Walleij wrote: Hi Mika, On Wed, Feb 27, 2013 at 4:25 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: -static int ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr) +static bool ichx_gpio_check_available(struct

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-03 Thread Jean Delvare
Hi all, On Sat, 02 Mar 2013 09:18:36 +, Grant Likely wrote: > On Wed, 27 Feb 2013 17:25:15 +0200, Mika Westerberg > wrote: > > ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether > > the given GPIO is available or not. However, callers of this function treat > > the

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-03 Thread Grant Likely
On Wed, 27 Feb 2013 17:25:15 +0200, Mika Westerberg wrote: > ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether > the given GPIO is available or not. However, callers of this function treat > the return value as boolean: > > ... > if

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-03 Thread Grant Likely
On Wed, 27 Feb 2013 17:25:15 +0200, Mika Westerberg mika.westerb...@linux.intel.com wrote: ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether the given GPIO is available or not. However, callers of this function treat the return value as boolean: ... if

Re: [PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-03-03 Thread Jean Delvare
Hi all, On Sat, 02 Mar 2013 09:18:36 +, Grant Likely wrote: On Wed, 27 Feb 2013 17:25:15 +0200, Mika Westerberg mika.westerb...@linux.intel.com wrote: ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether the given GPIO is available or not. However, callers of

[PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-02-27 Thread Mika Westerberg
ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether the given GPIO is available or not. However, callers of this function treat the return value as boolean: ... if (!ichx_gpio_check_available(gpio, nr)) return -ENXIO; which erroneusly fails

[PATCH] gpio: gpio-ich: fix ichx_gpio_check_available() return what callers expect

2013-02-27 Thread Mika Westerberg
ichx_gpio_check_available() returns either 0 or -ENXIO depending on whether the given GPIO is available or not. However, callers of this function treat the return value as boolean: ... if (!ichx_gpio_check_available(gpio, nr)) return -ENXIO; which erroneusly fails