Re: [PATCH] gpio: msm-v1: Fix typo in function argument

2014-10-30 Thread Linus Walleij
On Fri, Oct 24, 2014 at 4:29 PM, Daniel Thompson wrote: > irq_set_irq_wake() treats its second argument as a boolean. It is much > easier to read code when constant booleans are either 0 or 1! > > This particular line of code distracted me somewhat when I was doing a bit of > work in a code brows

Re: [PATCH] gpio: msm-v1: Fix typo in function argument

2014-10-26 Thread Alexandre Courbot
On Fri, Oct 24, 2014 at 11:29 PM, Daniel Thompson wrote: > irq_set_irq_wake() treats its second argument as a boolean. It is much > easier to read code when constant booleans are either 0 or 1! > > This particular line of code distracted me somewhat when I was doing a bit of > work in a code brows

[PATCH] gpio: msm-v1: Fix typo in function argument

2014-10-24 Thread Daniel Thompson
irq_set_irq_wake() treats its second argument as a boolean. It is much easier to read code when constant booleans are either 0 or 1! This particular line of code distracted me somewhat when I was doing a bit of work in a code browser since it (spuriously) got me worried that I had misunderstood ho