Re: [PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:27 AM, Axel Lin wrote: > We call pinctrl_request_gpio() in request callback, thus we need to call > pinctrl_free_gpio() in free callback. > > Both mvebu_gpio_request() and mvebu_gpio_free() are not referenced outside of > this file, make them static. > > Signed-off-by:

Re: [PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-08 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:27 AM, Axel Lin axel@ingics.com wrote: We call pinctrl_request_gpio() in request callback, thus we need to call pinctrl_free_gpio() in free callback. Both mvebu_gpio_request() and mvebu_gpio_free() are not referenced outside of this file, make them static.

Re: [PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-07 Thread Thomas Petazzoni
On Thu, 08 Nov 2012 10:27:29 +0800, Axel Lin wrote: > We call pinctrl_request_gpio() in request callback, thus we need to call > pinctrl_free_gpio() in free callback. > > Both mvebu_gpio_request() and mvebu_gpio_free() are not referenced outside of > this file, make them static. Indeed, thanks.

[PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-07 Thread Axel Lin
We call pinctrl_request_gpio() in request callback, thus we need to call pinctrl_free_gpio() in free callback. Both mvebu_gpio_request() and mvebu_gpio_free() are not referenced outside of this file, make them static. Signed-off-by: Axel Lin --- drivers/gpio/gpio-mvebu.c |5 +++-- 1 file

[PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-07 Thread Axel Lin
We call pinctrl_request_gpio() in request callback, thus we need to call pinctrl_free_gpio() in free callback. Both mvebu_gpio_request() and mvebu_gpio_free() are not referenced outside of this file, make them static. Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/gpio-mvebu.c |

Re: [PATCH] gpio: mvebu: Set free callback for gpio_chip

2012-11-07 Thread Thomas Petazzoni
On Thu, 08 Nov 2012 10:27:29 +0800, Axel Lin wrote: We call pinctrl_request_gpio() in request callback, thus we need to call pinctrl_free_gpio() in free callback. Both mvebu_gpio_request() and mvebu_gpio_free() are not referenced outside of this file, make them static. Indeed, thanks.