Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

2018-05-23 Thread Linus Walleij
On Fri, May 4, 2018 at 6:53 PM, Grigoryev Denis wrote: > The driver stores the result of irq_set_type() in the internal variables > irq_trig_raise and irq_trig_fall, which later are used to determine > the GPIOs that must be re-configured as input. These variables retain their > value between gpi

Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

2018-05-16 Thread Andy Shevchenko
On Wed, 2018-05-16 at 14:51 +0200, Linus Walleij wrote: > On Fri, May 4, 2018 at 6:53 PM, Grigoryev Denis > wrote: > If it's full context below, the patch looks good enough to me (assuming it works and doesn't break things on other chips like PCAL variants). Though, I didn't read the code caref

Re: [PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

2018-05-16 Thread Linus Walleij
On Fri, May 4, 2018 at 6:53 PM, Grigoryev Denis wrote: > The driver stores the result of irq_set_type() in the internal variables > irq_trig_raise and irq_trig_fall, which later are used to determine > the GPIOs that must be re-configured as input. These variables retain their > value between gpi

[PATCH] gpio: pca953x: Clear irq trigger type on irq shutdown

2018-05-04 Thread Grigoryev Denis
The driver stores the result of irq_set_type() in the internal variables irq_trig_raise and irq_trig_fall, which later are used to determine the GPIOs that must be re-configured as input. These variables retain their value between gpiolib's export / unexport, resulting in an incorrect state in som