Re: [PATCH] gpio: pxa: fix legacy non pinctrl aware builds again

2018-11-15 Thread Linus Walleij
On Thu, Nov 15, 2018 at 6:16 PM Robert Jarzmik wrote: > As pointed out by Gregor, spitz keyboard matrix is broken, with or > without CONFIG_PINCTRL set, quoting : > "The gpio matrix keypard on the Zaurus C3x00 (see spitz.c) does not work > properly. Noticeable are that rshift+c does nothing

Re: [PATCH] gpio: pxa: fix legacy non pinctrl aware builds again

2018-11-15 Thread Linus Walleij
On Thu, Nov 15, 2018 at 6:16 PM Robert Jarzmik wrote: > As pointed out by Gregor, spitz keyboard matrix is broken, with or > without CONFIG_PINCTRL set, quoting : > "The gpio matrix keypard on the Zaurus C3x00 (see spitz.c) does not work > properly. Noticeable are that rshift+c does nothing

[PATCH] gpio: pxa: fix legacy non pinctrl aware builds again

2018-11-15 Thread Robert Jarzmik
As pointed out by Gregor, spitz keyboard matrix is broken, with or without CONFIG_PINCTRL set, quoting : "The gpio matrix keypard on the Zaurus C3x00 (see spitz.c) does not work properly. Noticeable are that rshift+c does nothing where as lshift+c creates C. Opposite it is for rshift+a vs

[PATCH] gpio: pxa: fix legacy non pinctrl aware builds again

2018-11-15 Thread Robert Jarzmik
As pointed out by Gregor, spitz keyboard matrix is broken, with or without CONFIG_PINCTRL set, quoting : "The gpio matrix keypard on the Zaurus C3x00 (see spitz.c) does not work properly. Noticeable are that rshift+c does nothing where as lshift+c creates C. Opposite it is for rshift+a vs

Re: [PATCH] gpio: pxa: fix legacy non pinctrl aware builds

2016-03-31 Thread Linus Walleij
On Tue, Mar 29, 2016 at 10:04 AM, Robert Jarzmik wrote: > In legacy pxa builds, ie. non device-tree and platform-data only builds, > pinctrl is not yet available. As a consequence, the pinctrl gpio > direction change function is a stub, returning always success. > > In

Re: [PATCH] gpio: pxa: fix legacy non pinctrl aware builds

2016-03-31 Thread Linus Walleij
On Tue, Mar 29, 2016 at 10:04 AM, Robert Jarzmik wrote: > In legacy pxa builds, ie. non device-tree and platform-data only builds, > pinctrl is not yet available. As a consequence, the pinctrl gpio > direction change function is a stub, returning always success. > > In the current state, the

[PATCH] gpio: pxa: fix legacy non pinctrl aware builds

2016-03-29 Thread Robert Jarzmik
In legacy pxa builds, ie. non device-tree and platform-data only builds, pinctrl is not yet available. As a consequence, the pinctrl gpio direction change function is a stub, returning always success. In the current state, the gpio driver direction function believes the pinctrl direction change

[PATCH] gpio: pxa: fix legacy non pinctrl aware builds

2016-03-29 Thread Robert Jarzmik
In legacy pxa builds, ie. non device-tree and platform-data only builds, pinctrl is not yet available. As a consequence, the pinctrl gpio direction change function is a stub, returning always success. In the current state, the gpio driver direction function believes the pinctrl direction change