Re: [PATCH] gpio / ACPI: Don't crash on NULL chip->dev

2014-04-10 Thread Linus Walleij
On Mon, Mar 31, 2014 at 2:16 PM, Mika Westerberg wrote: > Commit aa92b6f689ac (gpio / ACPI: Allocate ACPI specific data directly in > acpi_gpiochip_add()) moved ACPI handle checking to acpi_gpiochip_add() but > forgot to check whether chip->dev is NULL before dereferencing it. > > Since chip->dev

Re: [PATCH] gpio / ACPI: Don't crash on NULL chip->dev

2014-03-31 Thread Alexandre Courbot
On Mon, Mar 31, 2014 at 9:16 PM, Mika Westerberg wrote: > Commit aa92b6f689ac (gpio / ACPI: Allocate ACPI specific data directly in > acpi_gpiochip_add()) moved ACPI handle checking to acpi_gpiochip_add() but > forgot to check whether chip->dev is NULL before dereferencing it. > > Since chip->dev

Re: [PATCH] gpio / ACPI: Don't crash on NULL chip->dev

2014-03-31 Thread Sabrina Dubroca
2014-03-31, 15:16:49 +0300, Mika Westerberg wrote: > Commit aa92b6f689ac (gpio / ACPI: Allocate ACPI specific data directly in > acpi_gpiochip_add()) moved ACPI handle checking to acpi_gpiochip_add() but > forgot to check whether chip->dev is NULL before dereferencing it. > > Since chip->dev point

[PATCH] gpio / ACPI: Don't crash on NULL chip->dev

2014-03-31 Thread Mika Westerberg
Commit aa92b6f689ac (gpio / ACPI: Allocate ACPI specific data directly in acpi_gpiochip_add()) moved ACPI handle checking to acpi_gpiochip_add() but forgot to check whether chip->dev is NULL before dereferencing it. Since chip->dev pointer is optional we can end up with crash like following: BUG