Re: [PATCH] gpiolib: fix bug and clarify OF use of ranges

2012-11-20 Thread Linus Walleij
On Wed, Nov 21, 2012 at 8:42 AM, Viresh Kumar wrote: > Reviewed-by: Viresh Kumar > > This is what i was asking you earlier: "Doesn't gpiochip_add_pin_range > have any users?" and you said NO and i didn't cross checked :( Yes I forgot that I refactored the OF code to actually use this function..

Re: [PATCH] gpiolib: fix bug and clarify OF use of ranges

2012-11-20 Thread Linus Walleij
On Wed, Nov 21, 2012 at 8:37 AM, Linus Walleij wrote: > From: Linus Walleij > > In commit c905165f5946f56dca195871641bd4e488eca24a > "gpiolib: let gpiochip_add_pin_range() specify offset" > I forgot to update the OF use of the function > gpiochip_add_pin_range(). > > It turns out that this revea

Re: [PATCH] gpiolib: fix bug and clarify OF use of ranges

2012-11-20 Thread Viresh Kumar
On 21 November 2012 13:07, Linus Walleij wrote: > From: Linus Walleij > > In commit c905165f5946f56dca195871641bd4e488eca24a > "gpiolib: let gpiochip_add_pin_range() specify offset" > I forgot to update the OF use of the function > gpiochip_add_pin_range(). > > It turns out that this reveal a wea

[PATCH] gpiolib: fix bug and clarify OF use of ranges

2012-11-20 Thread Linus Walleij
From: Linus Walleij In commit c905165f5946f56dca195871641bd4e488eca24a "gpiolib: let gpiochip_add_pin_range() specify offset" I forgot to update the OF use of the function gpiochip_add_pin_range(). It turns out that this reveal a weakness in the OF range mappings: ranges cannot currently be spar