Re: [PATCH] groups: don't return unmapped gids in getgroups(2)

2017-02-20 Thread Djalal Harouni
On Thu, Feb 16, 2017 at 7:19 PM, Eric W. Biederman wrote: > > Added a few more relevant mailing-lists to the CC list. > > Aleksa Sarai writes: > >> One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to >> disable setgroups on a per user namespace basis") is that because >> setgroups

Re: [PATCH] groups: don't return unmapped gids in getgroups(2)

2017-02-17 Thread Mike Frysinger
On Fri, Feb 17, 2017 at 12:53 PM, Aleksa Sarai wrote: > One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to > disable setgroups on a per user namespace basis") is that because > setgroups(2) no longer works in user namespaces it doesn't make any > sense to be ret

Re: [PATCH] groups: don't return unmapped gids in getgroups(2)

2017-02-17 Thread Aleksa Sarai
One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to disable setgroups on a per user namespace basis") is that because setgroups(2) no longer works in user namespaces it doesn't make any sense to be returning weird group IDs that the process cannot do anythi

Re: [PATCH] groups: don't return unmapped gids in getgroups(2)

2017-02-17 Thread Andy Lutomirski
On Fri, Feb 17, 2017 at 12:44 AM, Aleksa Sarai wrote: >>> One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to >>> disable setgroups on a per user namespace basis") is that because >>> setgroups(2) no longer works in user namespaces it doesn't make any >>> sense to be returning weir

Re: [PATCH] groups: don't return unmapped gids in getgroups(2)

2017-02-17 Thread Aleksa Sarai
One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to disable setgroups on a per user namespace basis") is that because setgroups(2) no longer works in user namespaces it doesn't make any sense to be returning weird group IDs that the process cannot do anything with. This code work

Re: [PATCH] groups: don't return unmapped gids in getgroups(2)

2017-02-16 Thread Eric W. Biederman
Added a few more relevant mailing-lists to the CC list. Aleksa Sarai writes: > One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to > disable setgroups on a per user namespace basis") is that because > setgroups(2) no longer works in user namespaces it doesn't make any > sense to

[PATCH] groups: don't return unmapped gids in getgroups(2)

2017-02-16 Thread Aleksa Sarai
One thing overlooked by commit 9cc46516ddf4 ("userns: Add a knob to disable setgroups on a per user namespace basis") is that because setgroups(2) no longer works in user namespaces it doesn't make any sense to be returning weird group IDs that the process cannot do anything with. This change, alo