Re: [PATCH] gsmi: Replace printk with relevant pr_

2019-06-12 Thread Guenter Roeck
When running checkpatch on the attachment, I get lots of ERROR: DOS line endings plus WARNING: Possible unnecessary 'out of memory' message Hmm ... ok, the latter is a different issue, but it kind of contradicts "This also helps avoid checkpatch warnings". Guenter On Wed, Jun 12, 2019 at 7:2

Re: [PATCH] gsmi: Replace printk with relevant pr_

2019-06-12 Thread Greg KH
On Wed, Jun 12, 2019 at 07:57:27PM +0530, Saiyam Doshi wrote: > >From 3a9cec48147b24fd9d793e0fdf20058461445646 Mon Sep 17 00:00:00 2001 > From: Saiyam Doshi > Date: Tue, 11 Jun 2019 19:21:50 +0530 > Subject: [PATCH] gsmi: Replace printk with relevant pr_ Why is all of this in the

[PATCH] gsmi: Replace printk with relevant pr_

2019-06-12 Thread Saiyam Doshi
>From 3a9cec48147b24fd9d793e0fdf20058461445646 Mon Sep 17 00:00:00 2001 From: Saiyam Doshi Date: Tue, 11 Jun 2019 19:21:50 +0530 Subject: [PATCH] gsmi: Replace printk with relevant pr_ Replace printk() with pr_* macros for logging consistency. This also helps avoid checkpatch warnings. Sig