Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, 2015-12-10 at 13:55 +0800, kbuild test robot wrote: > Hi Joe, Hello Fengguang. Thanks for the report.  I'll fix and resubmit. > > > include/linux/printk.h:430:24: sparse: undefined identifier 'BIT' > > > include/linux/printk.h:430:27: sparse: bad constant expression type -- To

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

Hi Joe, [auto build test WARNING on v4.4-rc4] [also build test WARNING on next-20151209] url: https://github.com/0day-ci/linux/commits/Joe-Perches/hexdump-Add-ability-to-do-endian-conversions-in-print_hex_dump-functions/20151210-060244 reproduce: # apt-get install sparse make

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, 2015-12-10 at 01:09 +0200, Andy Shevchenko wrote: > On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko > wrote: > > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: > > > There are use cases for dumping buffers with specific endian types > > > for 2, 4, and 8 byte variables in arrays.

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: >> There are use cases for dumping buffers with specific endian types >> for 2, 4, and 8 byte variables in arrays. >> >> Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 2015-12-09 at 14:45 -0800, Andrew Morton wrote: > On Wed, 09 Dec 2015 14:16:36 -0800 Joe Perches wrote: > > > Will patches be forthcoming to convert them? > > Sure, after a settling period for Masahiro's patch > > to be applied upstream. > > > > https://lkml.org/lkml/2015/12/8/480 > >

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 09 Dec 2015 14:16:36 -0800 Joe Perches wrote: > On Wed, 2015-12-09 at 14:09 -0800, Andrew Morton wrote: > > On Wed,9 Dec 2015 13:59:30 -0800 Joe Perches wrote: > > > > > There are use cases for dumping buffers with specific endian types > > > for 2, 4, and 8 byte variables in

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, 2015-12-10 at 00:11 +0200, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: [] > > diff --git a/lib/hexdump.c b/lib/hexdump.c [] > > @@ -216,7 +240,10 @@ EXPORT_SYMBOL(hex_dump_to_buffer); > >   * @prefix_type: controls whether prefix of an offset, address, or

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 2015-12-09 at 14:09 -0800, Andrew Morton wrote: > On Wed,  9 Dec 2015 13:59:30 -0800 Joe Perches wrote: > > > There are use cases for dumping buffers with specific endian types > > for 2, 4, and 8 byte variables in arrays. > > > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: > There are use cases for dumping buffers with specific endian types > for 2, 4, and 8 byte variables in arrays. > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such. > > Rename groupsize to groupflags in the functions and

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 9 Dec 2015 13:59:30 -0800 Joe Perches wrote: > There are use cases for dumping buffers with specific endian types > for 2, 4, and 8 byte variables in arrays. > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such. > > Rename groupsize to groupflags in the functions

[PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

There are use cases for dumping buffers with specific endian types for 2, 4, and 8 byte variables in arrays. Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such. Rename groupsize to groupflags in the functions and add documentation to the kernel-doc to describe the use of the

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 2015-12-09 at 14:09 -0800, Andrew Morton wrote: > On Wed,  9 Dec 2015 13:59:30 -0800 Joe Perches wrote: > > > There are use cases for dumping buffers with specific endian types > > for 2, 4, and 8 byte variables in arrays. > > > > Add an enum for DUMP_TYPE_(LE|BE|CPU)

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 09 Dec 2015 14:16:36 -0800 Joe Perches wrote: > On Wed, 2015-12-09 at 14:09 -0800, Andrew Morton wrote: > > On Wed,9 Dec 2015 13:59:30 -0800 Joe Perches wrote: > > > > > There are use cases for dumping buffers with specific endian types > > > for

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: > There are use cases for dumping buffers with specific endian types > for 2, 4, and 8 byte variables in arrays. > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such. > > Rename groupsize to groupflags in

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, 2015-12-10 at 00:11 +0200, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: [] > > diff --git a/lib/hexdump.c b/lib/hexdump.c [] > > @@ -216,7 +240,10 @@ EXPORT_SYMBOL(hex_dump_to_buffer); > >   * @prefix_type: controls whether prefix of an

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 9 Dec 2015 13:59:30 -0800 Joe Perches wrote: > There are use cases for dumping buffers with specific endian types > for 2, 4, and 8 byte variables in arrays. > > Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such. > > Rename groupsize to groupflags

[PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

There are use cases for dumping buffers with specific endian types for 2, 4, and 8 byte variables in arrays. Add an enum for DUMP_TYPE_(LE|BE|CPU) to enable emitting them as such. Rename groupsize to groupflags in the functions and add documentation to the kernel-doc to describe the use of the

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Wed, 2015-12-09 at 14:45 -0800, Andrew Morton wrote: > On Wed, 09 Dec 2015 14:16:36 -0800 Joe Perches wrote: > > > Will patches be forthcoming to convert them? > > Sure, after a settling period for Masahiro's patch > > to be applied upstream. > > > >

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, 2015-12-10 at 01:09 +0200, Andy Shevchenko wrote: > On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko > wrote: > > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: > > > There are use cases for dumping buffers with specific endian types > >

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, Dec 10, 2015 at 12:11 AM, Andy Shevchenko wrote: > On Wed, Dec 9, 2015 at 11:59 PM, Joe Perches wrote: >> There are use cases for dumping buffers with specific endian types >> for 2, 4, and 8 byte variables in arrays. >> >> Add an enum for

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

On Thu, 2015-12-10 at 13:55 +0800, kbuild test robot wrote: > Hi Joe, Hello Fengguang. Thanks for the report.  I'll fix and resubmit. > > > include/linux/printk.h:430:24: sparse: undefined identifier 'BIT' > > > include/linux/printk.h:430:27: sparse: bad constant expression type -- To

Re: [PATCH] hexdump: Add ability to do endian conversions in print_hex_dump functions

Hi Joe, [auto build test WARNING on v4.4-rc4] [also build test WARNING on next-20151209] url: https://github.com/0day-ci/linux/commits/Joe-Perches/hexdump-Add-ability-to-do-endian-conversions-in-print_hex_dump-functions/20151210-060244 reproduce: # apt-get install sparse make