Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-02 Thread Dmitry Torokhov
On 4/2/07, Dan Engel <[EMAIL PROTECTED]> wrote: On a side note, I'm not sure why those input key events are there. The basic idea of the device is that you can switch KVM control back and forth, while keeping audio on a single computer (e.g., to listen to music), and at first I thought those key

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-02 Thread Dan Engel
On Mon, 2007-04-02 at 09:06 -0400, Dmitry Torokhov wrote: > It may be a HID-class device but it is definetly not an input device > and it would be wrong to present it to userspace as a device having 2 > LEDs on it - it would be a lie. If we did that then some application > might mistake the device

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-02 Thread Dmitry Torokhov
On 4/2/07, Dan Engel <[EMAIL PROTECTED]> wrote: On Mon, 2007-04-02 at 00:04 -0400, Dmitry Torokhov wrote: > Actually I want to keep input subystm out of the loop here, since LEDs > such as mail, charging, etc have nothing to do with user input but > rather reflect overall system/application stat

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-02 Thread Dan Engel
On Mon, 2007-04-02 at 00:04 -0400, Dmitry Torokhov wrote: > Actually I want to keep input subystm out of the loop here, since LEDs > such as mail, charging, etc have nothing to do with user input but > rather reflect overall system/application state. > What if I just added a HID_QUIRK_HIDDEV for

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-01 Thread Dmitry Torokhov
Hi Dan, On Sunday 01 April 2007 23:28, Dan Engel wrote: > On Sun, 2007-04-01 at 19:43 +0200, Jiri Kosina wrote: > > On Sun, 1 Apr 2007, Dmitry Torokhov wrote: > > > > > No, I do not want to add any more LED constants to input. In fact I > > > think that adding constants beyond keyboard indicator

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-01 Thread Dan Engel
On Sun, 2007-04-01 at 19:43 +0200, Jiri Kosina wrote: > On Sun, 1 Apr 2007, Dmitry Torokhov wrote: > > > No, I do not want to add any more LED constants to input. In fact I > > think that adding constants beyond keyboard indicators was a mistake. We > > have led subsystem that provides interface

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-01 Thread Jiri Kosina
On Sun, 1 Apr 2007, Dmitry Torokhov wrote: > No, I do not want to add any more LED constants to input. In fact I > think that adding constants beyond keyboard indicators was a mistake. We > have led subsystem that provides interface to control arbitrary leds and > we should use it. Ah, of cour

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-01 Thread Dmitry Torokhov
On Sunday 01 April 2007 05:01, Jiri Kosina wrote: > On Sat, 31 Mar 2007, Dan Engel wrote: > > > This patch is really being offered because it's what's needed to make the > > operation > > of the Belkin Flip USB KVM switch avaiable to user-space programs through > > the HID input > > event interf

Re: [PATCH] hid: add two led codes to hid input mapping

2007-04-01 Thread Jiri Kosina
On Sat, 31 Mar 2007, Dan Engel wrote: > This patch is really being offered because it's what's needed to make the > operation > of the Belkin Flip USB KVM switch avaiable to user-space programs through the > HID input > event interface. The Belkin Flip KVM overloads LED usages to give software

[PATCH] hid: add two led codes to hid input mapping

2007-03-31 Thread Dan Engel
From: Daniel P. Engel <[EMAIL PROTECTED]> Add the "Off-hook" and "Speaker" LED codes 0xb and 0xc to the hid-input configuration, mapping them to the 0x17 and 0x1e usages in the HID usage table. Signed-off-by: Daniel P. Engel <[EMAIL PROTECTED]> --- This patch is really being offered because it's